Support for Int64 and fix for the root reference.

Support for Int64 and fix for the root reference.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/48a4c3d72ea66b5fafaf798d633700a0223b6a45

[Paul Berry, 2016-01-08 18:11:18]

lgtm assuming issue below is fixed.

https://codereview.chromium.org/1571593002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/flat_buffers.dart (right):

https://codereview.chromium.org/1571593002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:192: _setUint32AtTail(_buf,
alignedTail, alignedTail - offset._tail);
This won't work either.  Consider the case where _tail == 64, buf.lengthInBytes
== 68, and _maxAlign == 8 on entry to this function.  After the call to
_prepare, _tail will be 68.  Then we will set alignedTail to 72, and the call to
_setUint32AtTail will underflow the buffer.

Perhaps this would work:

_prepare(max(4, _maxAlign), 1);
_setUint32AtTail(...);

[scheglov, 2016-01-08 18:39:07]

https://codereview.chromium.org/1571593002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/flat_buffers.dart (right):

https://codereview.chromium.org/1571593002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/flat_buffers.dart:192: _setUint32AtTail(_buf,
alignedTail, alignedTail - offset._tail);
On 2016/01/08 18:11:18, Paul Berry wrote:
> This won't work either.  Consider the case where _tail == 64,
buf.lengthInBytes
> == 68, and _maxAlign == 8 on entry to this function.  After the call to
> _prepare, _tail will be 68.  Then we will set alignedTail to 72, and the call
to
> _setUint32AtTail will underflow the buffer.
> 
> Perhaps this would work:
> 
> _prepare(max(4, _maxAlign), 1);
> _setUint32AtTail(...);

Done.

[scheglov, 2016-01-08 18:39:35]

Description was changed from

==========
Support for Int64 and fix for the root reference.

R=paulberry@google.com
BUG=
==========

to

==========
Support for Int64 and fix for the root reference.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/48a4c3d72ea66b5fafaf798d633700a0223b6a45
==========

[scheglov, 2016-01-08 18:39:36]

Committed patchset #1 (id:1) manually as
48a4c3d72ea66b5fafaf798d633700a0223b6a45 (presubmit successful).