Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(602)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1571563003: [regexp] quantifier refers to the surrogate pair in unicode regexp. (Closed)

Created:
4 years, 11 months ago by Yang
Modified:
4 years, 11 months ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@unicoderegexpatom
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[regexp] quantifier refers to the surrogate pair in unicode regexp. R=rossberg@chromium.org Committed: https://crrev.com/8645a5ccd0c56799d135ae766f36fa89394b8aa2 Cr-Commit-Position: refs/heads/master@{#33209}

Patch Set 1 #

Patch Set 2 : add parse tests #

Total comments: 2

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -8 lines) Patch
M src/regexp/regexp-parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/regexp/regexp-parser.cc View 1 2 4 chunks +25 lines, -7 lines 0 comments Download
M test/cctest/test-regexp.cc View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M test/mjsunit/harmony/unicode-escapes-in-regexps.js View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Yang
4 years, 11 months ago (2016-01-08 14:21:16 UTC) #1
rossberg
lgtm https://codereview.chromium.org/1571563003/diff/20001/src/regexp/regexp-parser.cc File src/regexp/regexp-parser.cc (right): https://codereview.chromium.org/1571563003/diff/20001/src/regexp/regexp-parser.cc#newcode465 src/regexp/regexp-parser.cc:465: if (unicode_) { Nit: is this if necessary? ...
4 years, 11 months ago (2016-01-11 12:25:42 UTC) #2
Yang
https://codereview.chromium.org/1571563003/diff/20001/src/regexp/regexp-parser.cc File src/regexp/regexp-parser.cc (right): https://codereview.chromium.org/1571563003/diff/20001/src/regexp/regexp-parser.cc#newcode465 src/regexp/regexp-parser.cc:465: if (unicode_) { On 2016/01/11 12:25:41, rossberg wrote: > ...
4 years, 11 months ago (2016-01-11 14:41:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571563003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571563003/40001
4 years, 11 months ago (2016-01-11 14:41:56 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-11 15:07:00 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 15:08:10 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/8645a5ccd0c56799d135ae766f36fa89394b8aa2
Cr-Commit-Position: refs/heads/master@{#33209}

Powered by Google App Engine
This is Rietveld 408576698