Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 15715022: Remove the media query expressions serialization cache (Closed)

Created:
7 years, 6 months ago by kenneth.r.christiansen
Modified:
7 years, 6 months ago
Reviewers:
apavlov, darktears, eseidel
CC:
blink-reviews, apavlov+blink_chromium.org, dglazkov+blink, eae+blinkwatch, kenneth.christiansen, darktears
Visibility:
Public.

Description

Remove the media query expressions serialization cache It is not needed as the expressions are not individually accessible from CSSOM, and I suppose the cache only existed as the serialization was done twice during creating of the MediaQuery object. That is not needed as you can compare the MediaQueryExp directly. R=apavlov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151653

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M Source/core/css/MediaQuery.cpp View 2 chunks +7 lines, -7 lines 2 comments Download
M Source/core/css/MediaQueryExp.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/MediaQueryExp.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kenneth.r.christiansen
7 years, 6 months ago (2013-05-31 15:50:50 UTC) #1
apavlov
LGTM with comments https://codereview.chromium.org/15715022/diff/1/Source/core/css/MediaQuery.cpp File Source/core/css/MediaQuery.cpp (right): https://codereview.chromium.org/15715022/diff/1/Source/core/css/MediaQuery.cpp#newcode101 Source/core/css/MediaQuery.cpp:101: // If not all of the ...
7 years, 6 months ago (2013-06-03 11:17:02 UTC) #2
kenneth.r.christiansen
> https://codereview.chromium.org/15715022/diff/1/Source/core/css/MediaQuery.cpp#newcode105 > Source/core/css/MediaQuery.cpp:105: if (key && *exp == *key) > This looks suspicious (and ...
7 years, 6 months ago (2013-06-03 11:57:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/15715022/1
7 years, 6 months ago (2013-06-03 12:25:43 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8393
7 years, 6 months ago (2013-06-03 13:58:47 UTC) #5
kenneth.r.christiansen
7 years, 6 months ago (2013-06-03 14:16:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r151653 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698