Issue 15715012: Decrease GPU drawn brightness for < 1 pixel wide/high rects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15715012: Decrease GPU drawn brightness for < 1 pixel wide/high rects (Closed)

Created:
7 years, 7 months ago by robertphillips

Modified:
7 years, 6 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This gives a better answer for < 1 pixel wide/high rects but is still a bit geometrically alias-y.

Patch Set 2 : Address code review comment #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -3 lines)			Patch
	M	src/gpu/GrAARectRenderer.cpp	View	1	4 chunks	+19 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm with a question/suggestion. https://codereview.chromium.org/15715012/diff/1/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): https://codereview.chromium.org/15715012/diff/1/src/gpu/GrAARectRenderer.cpp#newcode466 src/gpu/GrAARectRenderer.cpp:466: innerColor = GrColorPackRGBA(SkAlphaMul(GrColorUnpackR(temp), scale), Is ...

7 years, 7 months ago (2013-05-24 18:42:01 UTC) #2

robertphillips

https://codereview.chromium.org/15715012/diff/1/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): https://codereview.chromium.org/15715012/diff/1/src/gpu/GrAARectRenderer.cpp#newcode466 src/gpu/GrAARectRenderer.cpp:466: innerColor = GrColorPackRGBA(SkAlphaMul(GrColorUnpackR(temp), scale), Maybe ... done.

7 years, 7 months ago (2013-05-24 19:20:20 UTC) #3

Message was sent while issue was closed.

committed as r9288

Expand Messages | Collapse Messages

Issue 15715012: Decrease GPU drawn brightness for < 1 pixel wide/high rects (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address code review comment #

Messages