Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 15715012: Decrease GPU drawn brightness for < 1 pixel wide/high rects (Closed)

Created:
7 years, 7 months ago by robertphillips
Modified:
7 years, 6 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This gives a better answer for < 1 pixel wide/high rects but is still a bit geometrically alias-y.

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address code review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M src/gpu/GrAARectRenderer.cpp View 1 4 chunks +19 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
robertphillips
7 years, 7 months ago (2013-05-24 18:30:24 UTC) #1
bsalomon
lgtm with a question/suggestion. https://codereview.chromium.org/15715012/diff/1/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): https://codereview.chromium.org/15715012/diff/1/src/gpu/GrAARectRenderer.cpp#newcode466 src/gpu/GrAARectRenderer.cpp:466: innerColor = GrColorPackRGBA(SkAlphaMul(GrColorUnpackR(temp), scale), Is ...
7 years, 7 months ago (2013-05-24 18:42:01 UTC) #2
robertphillips
https://codereview.chromium.org/15715012/diff/1/src/gpu/GrAARectRenderer.cpp File src/gpu/GrAARectRenderer.cpp (right): https://codereview.chromium.org/15715012/diff/1/src/gpu/GrAARectRenderer.cpp#newcode466 src/gpu/GrAARectRenderer.cpp:466: innerColor = GrColorPackRGBA(SkAlphaMul(GrColorUnpackR(temp), scale), Maybe ... done.
7 years, 7 months ago (2013-05-24 19:20:20 UTC) #3
robertphillips
7 years, 6 months ago (2013-05-28 13:16:34 UTC) #4
Message was sent while issue was closed.
committed as r9288

Powered by Google App Engine
This is Rietveld 408576698