Reland 201932: Add API function chrome.notifications.getAll

chrome/browser/notifications/notification_ui_manager_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/notification_ui_manager_mac.h"
 
 #include "base/mac/cocoa_protocols.h"
 #include "base/mac/mac_util.h"
 #include "base/strings/sys_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/balloon_notification_ui_manager.h"
 #include "chrome/browser/notifications/message_center_notification_manager.h"
+#include "chrome/browser/profiles/profile.h"
 #include "ui/message_center/message_center_util.h"
 
 @class NSUserNotificationCenter;
 
 // Since NSUserNotification and NSUserNotificationCenter are new classes in
 // 10.8, they cannot simply be declared with an @interface. An @implementation
 // is needed to link, but providing one would cause a runtime conflict when
 // running on 10.8. Instead, provide the interface defined as a protocol and
 // use that instead, because sizeof(id<Protocol>) == sizeof(Class*). In order to
 // instantiate, use NSClassFromString and simply assign the alloc/init'd result
@@ skipping 130 matching lines @@
     notification_map_.insert(std::make_pair(
         notification.notification_id(),
         new ControllerNotification(profile,
                                    ns_notification,
                                    new Notification(notification))));
 
     [GetNotificationCenter() deliverNotification:ns_notification];
   }
 }
 
+std::set<std::string>
+NotificationUIManagerMac::GetAllIdsByProfileAndSourceOrigin(
+  Profile* profile,

[jianli, 2013/05/24 21:51:20]

nit: 4-space indentation

[dewittj, 2013/05/24 23:03:22]

wow, clang-format-diff has made me lazy.  Done.

+  const GURL& source_origin) {
+  std::set<std::string> notification_ids =
+      BalloonNotificationUIManager::GetAllIdsByProfileAndSourceOrigin(
+          profile, source_origin);
+
+  for (NotificationMap::iterator it = notification_map_.begin();
+       it != notification_map_.end(); it++) {

[jianli, 2013/05/24 21:51:20]

nit: ++it

[dewittj, 2013/05/24 23:03:22]

Done.

+    if (it->second->model->origin_url() == source_origin &&

[jianli, 2013/05/24 21:51:20]

It might be better to use a temp variable to hold it->second since it is used in
multiple places.

[dewittj, 2013/05/24 23:03:22]

Done.

+        profile->IsSameProfile(it->second->profile)) {
+      // RemoveNotification will erase from the map, invalidating iterator

[jianli, 2013/05/24 21:51:20]

Not sure I understand this comment. RemoveNotification is not called in this
method.

[dewittj, 2013/05/24 23:03:22]

Done.

+      // references to the removed element.
+      notification_ids.insert(it->second->model->notification_id());
+    }
+  }
+
+  return notification_ids;
+}

[jianli, 2013/05/24 21:51:20]

nit: empty line

[dewittj, 2013/05/24 23:03:22]

Done.

 bool NotificationUIManagerMac::CancelById(const std::string& notification_id) {
   NotificationMap::iterator it = notification_map_.find(notification_id);
   if (it == notification_map_.end())
     return BalloonNotificationUIManager::CancelById(notification_id);
 
   return RemoveNotification(it->second->view);
 }
 
 bool NotificationUIManagerMac::CancelAllBySourceOrigin(
     const GURL& source_origin) {
@@ skipping 133 matching lines @@
     notification->Click();
 }
 
 - (BOOL)userNotificationCenter:(NSUserNotificationCenter*)center
      shouldPresentNotification:(id<CrUserNotification>)nsNotification {
   // Always display notifications, regardless of whether the app is foreground.
   return YES;
 }
 
 @end