Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: chrome/browser/managed_mode/managed_user_service.cc

Issue 15715005: Remove passphrase dialog and last parts of elevation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Also remove managed_user_passphrase_unittest. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/managed_mode/managed_user_service.cc
diff --git a/chrome/browser/managed_mode/managed_user_service.cc b/chrome/browser/managed_mode/managed_user_service.cc
index 96f1cc8771d6f60540f61fd0541fc9243b7855bd..6f1c4fab1de6cd87a1301f023229db7002b6416e 100644
--- a/chrome/browser/managed_mode/managed_user_service.cc
+++ b/chrome/browser/managed_mode/managed_user_service.cc
@@ -11,7 +11,6 @@
#include "base/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/extension_system.h"
-#include "chrome/browser/managed_mode/managed_mode_navigation_observer.h"
#include "chrome/browser/managed_mode/managed_mode_site_list.h"
#include "chrome/browser/managed_mode/managed_user_registration_service.h"
#include "chrome/browser/policy/managed_mode_policy_provider.h"
@@ -139,43 +138,6 @@ bool ManagedUserService::ProfileIsManaged(Profile* profile) {
return profile->GetPrefs()->GetBoolean(prefs::kProfileIsManaged);
}
-bool ManagedUserService::IsElevatedForWebContents(
- const content::WebContents* web_contents) const {
- const ManagedModeNavigationObserver* observer =
- ManagedModeNavigationObserver::FromWebContents(web_contents);
- return observer ? observer->is_elevated() : false;
-}
-
-bool ManagedUserService::IsPassphraseEmpty() const {
- PrefService* pref_service = profile_->GetPrefs();
- return pref_service->GetString(prefs::kManagedModeLocalPassphrase).empty();
-}
-
-bool ManagedUserService::CanSkipPassphraseDialog(
- const content::WebContents* web_contents) const {
-#if defined(OS_CHROMEOS)
- NOTREACHED();
-#endif
- return IsElevatedForWebContents(web_contents) ||
- IsPassphraseEmpty();
-}
-
-void ManagedUserService::RequestAuthorization(
- content::WebContents* web_contents,
- const PassphraseCheckedCallback& callback) {
-#if defined(OS_CHROMEOS)
- NOTREACHED();
-#endif
-
- if (CanSkipPassphraseDialog(web_contents)) {
- callback.Run(true);
- return;
- }
-
- // Is deleted automatically when the dialog is closed.
- new ManagedUserPassphraseDialog(web_contents, callback);
-}
-
// static
void ManagedUserService::RegisterUserPrefs(
user_prefs::PrefRegistrySyncable* registry) {
@@ -188,12 +150,6 @@ void ManagedUserService::RegisterUserPrefs(
registry->RegisterIntegerPref(
prefs::kDefaultManagedModeFilteringBehavior, ManagedModeURLFilter::ALLOW,
user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
- registry->RegisterStringPref(
- prefs::kManagedModeLocalPassphrase, std::string(),
- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
- registry->RegisterStringPref(
- prefs::kManagedModeLocalSalt, std::string(),
- user_prefs::PrefRegistrySyncable::UNSYNCABLE_PREF);
}
scoped_refptr<const ManagedModeURLFilter>
@@ -319,9 +275,6 @@ bool ManagedUserService::ExtensionManagementPolicyImpl(
if (elevated_for_testing_)
return true;
- if (elevated_for_extensions_.count(extension_id))
- return true;
-
if (error)
*error = l10n_util::GetStringUTF16(IDS_EXTENSIONS_LOCKED_MANAGED_MODE);
return false;

Powered by Google App Engine
This is Rietveld 408576698