Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Unified Diff: pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart

Issue 1571433002: dart2js cps: Compute intercepted classes in optimize_interceptors. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart
diff --git a/pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart b/pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart
index 8a941e70c6aa832bb9e3494b978dae051ce47f26..9daa9acf98c57a14e360a5f827b5de955fcc2ff3 100644
--- a/pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart
+++ b/pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart
@@ -1,7 +1,7 @@
library dart2js.cps_ir.backward_null_check_remover;
import 'cps_ir_nodes.dart';
-import 'optimizers.dart' show Pass;
+import 'optimizers.dart';
import '../common/names.dart';
import '../universe/selector.dart';
import 'type_mask_system.dart';
@@ -59,16 +59,12 @@ class BackwardNullCheckRemover extends BlockVisitor implements Pass {
if (prim is GetIndex) return prim.object;
if (prim is SetField) return prim.object;
if (prim is SetIndex) return prim.object;
- if (prim is InvokeMethod && !nullSelectors.contains(prim.selector)) {
+ if (prim is InvokeMethod && !selectorsOnNull.contains(prim.selector)) {
return prim.dartReceiverReference;
}
return null;
}
- static final List<Selector> nullSelectors = <Selector>[
- Selectors.equals, Selectors.hashCode_, Selectors.noSuchMethod_,
- Selectors.runtimeType_];
-
/// It has been determined that the null check in [prim] made redundant by
/// [newNullCheck]. Eliminate [prim] if it is not needed any more.
void tryEliminateRedundantNullCheck(Primitive prim, Primitive newNullCheck) {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698