Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 15714005: Deprecate HAllocateObject in favor of HAllocate. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Deprecate HAllocateObject in favor of HAllocate. This models the instantiation of an implicit receiver for CallNew nodes in hydrogen using HAllocate together with generic stores instead of one specialized HAllocateObject instruction, hence creating a single choking point for inlined allocation in optimized code. R=hpayer@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14930

Patch Set 1 #

Total comments: 4

Patch Set 2 : Addressed comments by Hannes Payer. #

Patch Set 3 : Addressed moar comments by Hannes Payer. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -490 lines) Patch
M src/arm/lithium-arm.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/arm/lithium-arm.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M src/heap.cc View 2 chunks +2 lines, -8 lines 0 comments Download
M src/hydrogen.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 2 3 chunks +67 lines, -9 lines 0 comments Download
M src/hydrogen-instructions.h View 1 6 chunks +12 lines, -44 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -89 lines 0 comments Download
M src/ia32/lithium-ia32.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +0 lines, -74 lines 0 comments Download
M src/mips/lithium-mips.h View 2 chunks +0 lines, -16 lines 0 comments Download
M src/mips/lithium-mips.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/objects.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +0 lines, -88 lines 0 comments Download
M src/x64/lithium-x64.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
7 years, 6 months ago (2013-06-03 12:05:20 UTC) #1
Hannes Payer (out of office)
LGTM! just a few nits https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h#newcode4848 src/hydrogen-instructions.h:4848: } add newline https://codereview.chromium.org/15714005/diff/1/src/hydrogen.cc ...
7 years, 6 months ago (2013-06-04 07:44:19 UTC) #2
Michael Starzinger
Addressed comments. Landing. https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h#newcode4848 src/hydrogen-instructions.h:4848: } On 2013/06/04 07:44:19, Hannes Payer ...
7 years, 6 months ago (2013-06-04 08:17:32 UTC) #3
Michael Starzinger
7 years, 6 months ago (2013-06-04 08:28:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r14930 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698