Deprecate HAllocateObject in favor of HAllocate.

Deprecate HAllocateObject in favor of HAllocate.

This models the instantiation of an implicit receiver for CallNew nodes
in hydrogen using HAllocate together with generic stores instead of one
specialized HAllocateObject instruction, hence creating a single choking
point for inlined allocation in optimized code.

R=hpayer@chromium.org

Committed: http://code.google.com/p/v8/source/detail?r=14930

[Hannes Payer (out of office), 2013-06-04 07:44:19]

LGTM! just a few nits

https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:4848: }
add newline

https://codereview.chromium.org/15714005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/15714005/diff/1/src/hydrogen.cc#newcode8861
src/hydrogen.cc:8861: initial_map_value->DeleteAndReplaceWith(NULL);
Should we create a separate function for that piece of code?
RemoveInstructions(HInstruction* instruction, Handle<Map>map);

[Michael Starzinger, 2013-06-04 08:17:32]

Addressed comments. Landing.

https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):

https://codereview.chromium.org/15714005/diff/1/src/hydrogen-instructions.h#n...
src/hydrogen-instructions.h:4848: }
On 2013/06/04 07:44:19, Hannes Payer wrote:
> add newline

Done.

https://codereview.chromium.org/15714005/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):

https://codereview.chromium.org/15714005/diff/1/src/hydrogen.cc#newcode8861
src/hydrogen.cc:8861: initial_map_value->DeleteAndReplaceWith(NULL);
On 2013/06/04 07:44:19, Hannes Payer wrote:
> Should we create a separate function for that piece of code?
> RemoveInstructions(HInstruction* instruction, Handle<Map>map);

As discussed offline: We decided not to provide a supporting function for this
removal of instruction because we consider it a hack and don't want to promote
hacks with supporting code. The correct way to solve this is with
non-destructive inlining that first tries to build a sub-graph before mutating
the parent graph. The TODO comment was adapted to reflect that.

[Michael Starzinger, 2013-06-04 08:28:48]

Committed patchset #3 manually as r14930 (presubmit successful).