Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 1571393006: server/discovery: add discovery service (Closed)

Created:
4 years, 11 months ago by nodir
Modified:
4 years, 11 months ago
Reviewers:
dnj, Vadim Sh., estaab, iannucci
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-go@prpc-server
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

server/discovery: add discovery service The discovery service accepts a list of service name and uses the descriptions in the registry. It exposes one method Describe that returns a list of service names and a file descriptor set that describes the services, their message and transitive dependencies. It is not prpc-specific R=iannucci@chromium.org, dnj@chromium.org, vadimsh@chromium.org, estaab@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/2a51ac93b38b1be1ae9ee2e102940d14610149f4

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+532 lines, -128 lines) Patch
M appengine/cmd/helloworld/frontend/handler.go View 1 2 chunks +2 lines, -0 lines 0 comments Download
A server/discovery/discovery.go View 1 1 chunk +94 lines, -0 lines 0 comments Download
A + server/discovery/generate.go View 1 chunk +1 line, -1 line 0 comments Download
A server/discovery/internal/testservices/discovery_test.go View 1 chunk +76 lines, -0 lines 0 comments Download
A + server/discovery/internal/testservices/generate.go View 1 chunk +1 line, -1 line 0 comments Download
A + server/discovery/internal/testservices/helloworld.proto View 1 1 chunk +1 line, -1 line 0 comments Download
A + server/discovery/internal/testservices/helloworld.pb.go View 1 9 chunks +57 lines, -55 lines 0 comments Download
A server/discovery/internal/testservices/pb.discovery.go View 1 chunk +68 lines, -0 lines 0 comments Download
A server/discovery/pb.discovery.go View 1 1 chunk +58 lines, -0 lines 0 comments Download
A server/discovery/service.proto View 1 chunk +27 lines, -0 lines 0 comments Download
A server/discovery/service.pb.go View 1 1 chunk +139 lines, -0 lines 0 comments Download
M server/prpc/generate.go View 1 1 chunk +1 line, -1 line 0 comments Download
D server/prpc/pb.discovery_test.go View 1 1 chunk +0 lines, -68 lines 0 comments Download
M tools/cmd/cproto/main.go View 1 2 chunks +7 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
nodir
PTAL
4 years, 11 months ago (2016-01-13 00:14:24 UTC) #1
iannucci
lgtm
4 years, 11 months ago (2016-01-13 21:17:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571393006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571393006/20001
4 years, 11 months ago (2016-01-15 23:52:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Luci-go Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-go%20Presubmit/builds/351)
4 years, 11 months ago (2016-01-15 23:54:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571393006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571393006/20001
4 years, 11 months ago (2016-01-16 00:53:09 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 00:55:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/2a51ac93b38b1be1ae9ee2e102940d14610149f4

Powered by Google App Engine
This is Rietveld 408576698