Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 1571373002: Revert of Componentize the favicon for chrome://history (Closed)

Created:
4 years, 11 months ago by Jamie Madill
Modified:
4 years, 11 months ago
Reviewers:
droger, sdefresne
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Componentize the favicon for chrome://history (patchset #2 id:120001 of https://codereview.chromium.org/1566983004/ ) Reason for revert: Possibly causing test failures on the Windows GPU FYI Release bots because of a missing resource. https://build.chromium.org/p/chromium.gpu.fyi/builders/Win8%20Release%20%28NVIDIA%29/builds/19266 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28NVIDIA%29/builds/20339 https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Release%20%28ATI%29/builds/16218 Original issue's description: > Componentize the favicon for chrome://history > > TBR=thakis > > Committed: https://crrev.com/1f69728f5099df74ada2bf45ae72a2d294aa3cdf > Cr-Commit-Position: refs/heads/master@{#368569} TBR=sdefresne@chromium.org,droger@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/fcb8ec70757048dfff810b36c55780d2e1d521a3 Cr-Commit-Position: refs/heads/master@{#368594}

Patch Set 1 #

Messages

Total messages: 6 (2 generated)
Jamie Madill
Created Revert of Componentize the favicon for chrome://history
4 years, 11 months ago (2016-01-11 15:56:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571373002/1
4 years, 11 months ago (2016-01-11 15:56:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-11 15:57:21 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-11 15:58:08 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fcb8ec70757048dfff810b36c55780d2e1d521a3
Cr-Commit-Position: refs/heads/master@{#368594}

Powered by Google App Engine
This is Rietveld 408576698