Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1571333004: Merge to XFA: Fix an infinite loop parsing in CPDF_SyntaxParser::GetObject() (Closed)

Created:
4 years, 11 months ago by Wei Li
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix an infinite loop parsing in CPDF_SyntaxParser::GetObject() CPDF_SyntaxParser::GetObject() may enter into an infinite loop when a signature dictionary doesn't have 'Contents' field. Add a check to avoid that. BUG=pdfium:344 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/1575833004 . (cherry picked from commit d3ab0f383f6736657480a8bb418c5e715a1aed3b) Committed: https://pdfium.googlesource.com/pdfium/+/f2b300af96e05bb372664752a64f6ab506820a12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
A testing/resources/bug_344.pdf View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Wei Li
Clean merge, TBR
4 years, 11 months ago (2016-01-11 22:15:48 UTC) #1
Wei Li
Committed patchset #1 (id:1) manually as f2b300af96e05bb372664752a64f6ab506820a12 (presubmit successful).
4 years, 11 months ago (2016-01-11 22:16:15 UTC) #3
Lei Zhang
4 years, 11 months ago (2016-01-11 22:53:17 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698