Issue 1571293003: Define intptr and uintptr in a more generic way

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1571293003: Define intptr and uintptr in a more generic way (Closed)

Created:
4 years, 11 months ago by labath

Modified:
4 years, 11 months ago

Reviewers:
Mark Mentovai

CC:
google-breakpad-dev_googlegroups.com

Base URL:
https://chromium.googlesource.com/breakpad/breakpad@master

Target Ref:
refs/heads/master

Visibility:
Public.

Define intptr and uintptr in a more generic way MSVC does not have the __PTRDIFF_TYPE__ macro defined, so I use the standard [u]intptr_t types instead. Compilation tested on windows, linux and mac. BUG= R=mark@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/860d7f5da1895c47bd07aecfff0d907ab177ad4b

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	src/common/dwarf/types.h	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Total messages: 5 (2 generated)

Mark Mentovai

4 years, 11 months ago (2016-01-11 17:38:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
860d7f5da1895c47bd07aecfff0d907ab177ad4b (presubmit successful).