Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1571263004: [turbofan] Replace MachineSemantic with Type in simplified lowering. (Closed)

Created:
4 years, 11 months ago by Jarin
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Replace MachineSemantic with Type in simplified lowering. Committed: https://crrev.com/b37e7861ceb83a5d8e1502ed43820b2c6a816353 Cr-Commit-Position: refs/heads/master@{#33222}

Patch Set 1 #

Patch Set 2 : Tweaks #

Patch Set 3 : Rename upper -> type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+572 lines, -431 lines) Patch
M src/compiler/representation-change.h View 1 2 chunks +18 lines, -13 lines 0 comments Download
M src/compiler/representation-change.cc View 1 12 chunks +98 lines, -91 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 35 chunks +271 lines, -186 lines 0 comments Download
M test/cctest/compiler/test-representation-change.cc View 32 chunks +183 lines, -139 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jarin
Could you take a look please?
4 years, 11 months ago (2016-01-11 23:01:06 UTC) #2
Benedikt Meurer
LGTM.
4 years, 11 months ago (2016-01-12 04:55:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571263004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571263004/40001
4 years, 11 months ago (2016-01-12 05:32:31 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-12 05:54:30 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 05:55:17 UTC) #8
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/b37e7861ceb83a5d8e1502ed43820b2c6a816353
Cr-Commit-Position: refs/heads/master@{#33222}

Powered by Google App Engine
This is Rietveld 408576698