Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Issue 1571243003: Remove assumption on absolute paths in java_cpp_enum.py. (Closed)

Created:
4 years, 11 months ago by kjellander_chromium
Modified:
4 years, 11 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, mikecase+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, fbarchard
Base URL:
http://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove assumption on absolute paths in java_cpp_enum.py. In java_cpp_enum.py there were assumptions on 'build' being a component of the absolute path of the script invoking the script. This leads to problems when other projects are using the Chromium build toolchain (in this case libyuv), where the script invoking GYP is located in the root of the project dir (https://chromium.googlesource.com/libyuv/libyuv/+/master/gyp_libyuv). BUG=libyuv:536 Committed: https://crrev.com/70ee602b6c186707286f9b5836a28311fe92e91e Cr-Commit-Position: refs/heads/master@{#368829}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M build/android/gyp/java_cpp_enum.py View 1 chunk +1 line, -4 lines 1 comment Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571243003/1
4 years, 11 months ago (2016-01-11 04:29:41 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-11 09:06:31 UTC) #4
kjellander_chromium
https://codereview.chromium.org/1571243003/diff/1/build/android/gyp/java_cpp_enum.py File build/android/gyp/java_cpp_enum.py (right): https://codereview.chromium.org/1571243003/diff/1/build/android/gyp/java_cpp_enum.py#newcode232 build/android/gyp/java_cpp_enum.py:232: return os.path.basename(os.path.abspath(sys.argv[0])) This returns the same result as before ...
4 years, 11 months ago (2016-01-11 09:19:55 UTC) #7
jbudorick
lgtm
4 years, 11 months ago (2016-01-11 14:29:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1571243003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1571243003/1
4 years, 11 months ago (2016-01-12 05:57:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-12 08:45:33 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 08:48:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70ee602b6c186707286f9b5836a28311fe92e91e
Cr-Commit-Position: refs/heads/master@{#368829}

Powered by Google App Engine
This is Rietveld 408576698