third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp - Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved ALLOW_NUMERIC_ARG_TYPES_PROMOTABLE_TO Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/ImageDecoder.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/jpeg/JPEGImageDecoder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

index 6a6465d4434f02835c55d78bb2dd13ab4a8a36b4..543f754e7d5824086371ec0f82c72453424c6feb 100644

--- a/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/ImageDecoderTestHelpers.cpp

@@ -75,8 +75,8 @@ void testByteByByteDecode(DecoderCreator createDecoder, const char* file, size_t

const char* source = data->data();

for (size_t length = 1; length <= data->size() && !decoder->failed(); ++length) {

- sourceData[0]->append(source, 1);

- sourceData[1]->append(source++, 1);

+ sourceData[0]->append(source, 1u);

+ sourceData[1]->append(source++, 1u);

// Alternate the buffers to cover the JPEGImageDecoder::onSetData restart code.

decoder->setData(sourceData[length & 1].get(), length == data->size());