third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp - Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved ALLOW_NUMERIC_ARG_TYPES_PROMOTABLE_TO Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/SharedBufferTest.cpp ('k') | third_party/WebKit/Source/platform/graphics/ImageFrameGeneratorTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

index 417b2c83380b653c727818f3283cce6931b85ed0..bb60190cba85be49ea519702927a2614fd2d2284 100644

--- a/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

+++ b/third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp

@@ -248,7 +248,7 @@ TEST_F(DeferredImageDecoderTest, singleFrameImageLoading)

EXPECT_TRUE(m_actualDecoder);

m_status = ImageFrame::FrameComplete;

- m_data->append(" ", 1);

+ m_data->append(" ", 1u);

m_lazyDecoder->setData(*m_data, true);

EXPECT_FALSE(m_actualDecoder);

EXPECT_TRUE(m_lazyDecoder->frameIsCompleteAtIndex(0));

@@ -277,7 +277,7 @@ TEST_F(DeferredImageDecoderTest, multiFrameImageLoading)

m_frameCount = 2;

m_frameDuration = 20;

m_status = ImageFrame::FrameComplete;

- m_data->append(" ", 1);

+ m_data->append(" ", 1u);

m_lazyDecoder->setData(*m_data, false);

image = m_lazyDecoder->createFrameAtIndex(0);