third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h - Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved ALLOW_NUMERIC_ARG_TYPES_PROMOTABLE_TO Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/DocumentLoader.cpp ('k') | third_party/WebKit/Source/core/loader/DocumentThreadableLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

diff --git a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

index cd794c47e24a1157939bc37ad9e6d000e58a233d..124db54f2dfb93e8f185dc556c7ab57434c3e541 100644

--- a/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

+++ b/third_party/WebKit/Source/core/loader/DocumentThreadableLoader.h

@@ -89,7 +89,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

void dataSent(Resource*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;

void responseReceived(Resource*, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>) override;

void setSerializedCachedMetadata(Resource*, const char*, size_t) override;

- void dataReceived(Resource*, const char* data, unsigned dataLength) override;

+ void dataReceived(Resource*, const char* data, size_t dataLength) override;

void redirectReceived(Resource*, ResourceRequest&, const ResourceResponse&) override;

void dataDownloaded(Resource*, int) override;

void didReceiveResourceTiming(Resource*, const ResourceTimingInfo&) override;

@@ -106,7 +106,7 @@ class CORE_EXPORT DocumentThreadableLoader final : public ThreadableLoader, priv

// |this| may be dead after calling these method in async mode.

void handleResponse(unsigned long identifier, const ResourceResponse&, PassOwnPtr<WebDataConsumerHandle>);

- void handleReceivedData(const char* data, unsigned dataLength);

+ void handleReceivedData(const char* data, size_t dataLength);

void handleSuccessfulFinish(unsigned long identifier, double finishTime);

// |this| may be dead after calling this method.