third_party/WebKit/Source/core/fetch/TextResource.cpp - Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/TextResource.cpp

Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: improved ALLOW_NUMERIC_ARG_TYPES_PROMOTABLE_TO Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/fetch/ScriptResource.cpp ('k') | third_party/WebKit/Source/core/html/imports/HTMLImportLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/TextResource.cpp

diff --git a/third_party/WebKit/Source/core/fetch/TextResource.cpp b/third_party/WebKit/Source/core/fetch/TextResource.cpp

index c8bc894a48703ab7ced74a729eaafb17477d5352..e651c6adcb62898f8d994b16410fc4849dd38dbd 100644

--- a/third_party/WebKit/Source/core/fetch/TextResource.cpp

+++ b/third_party/WebKit/Source/core/fetch/TextResource.cpp

@@ -36,8 +36,8 @@ String TextResource::decodedText() const

StringBuilder builder;

const char* data;

- unsigned position = 0;

- while (unsigned length = m_data->getSomeData(data, position)) {

+ size_t position = 0;

+ while (size_t length = m_data->getSomeData(data, position)) {

builder.append(m_decoder->decode(data, length));

position += length;

}