Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Side by Side Diff: third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp

Issue 1571233003: Fix errors caused by unsafe conversions to/from size_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: improved ALLOW_NUMERIC_ARG_TYPES_PROMOTABLE_TO Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Google Inc. All rights reserved. 2 * Copyright (c) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
43 43
44 class MemoryCacheTest : public ::testing::Test { 44 class MemoryCacheTest : public ::testing::Test {
45 public: 45 public:
46 class FakeDecodedResource : public Resource { 46 class FakeDecodedResource : public Resource {
47 public: 47 public:
48 FakeDecodedResource(const ResourceRequest& request, Type type) 48 FakeDecodedResource(const ResourceRequest& request, Type type)
49 : Resource(request, type) 49 : Resource(request, type)
50 { 50 {
51 } 51 }
52 52
53 virtual void appendData(const char* data, unsigned len) 53 virtual void appendData(const char* data, size_t len)
54 { 54 {
55 Resource::appendData(data, len); 55 Resource::appendData(data, len);
56 setDecodedSize(this->size()); 56 setDecodedSize(this->size());
57 } 57 }
58 58
59 protected: 59 protected:
60 void destroyDecodedDataIfPossible() override 60 void destroyDecodedDataIfPossible() override
61 { 61 {
62 setDecodedSize(0); 62 setDecodedSize(0);
63 } 63 }
(...skipping 467 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 531
532 WillBeHeapVector<RawPtrWillBeMember<Resource>> resources = memoryCache()->re sourcesForURL(url); 532 WillBeHeapVector<RawPtrWillBeMember<Resource>> resources = memoryCache()->re sourcesForURL(url);
533 EXPECT_EQ(2u, resources.size()); 533 EXPECT_EQ(2u, resources.size());
534 534
535 memoryCache()->evictResources(); 535 memoryCache()->evictResources();
536 EXPECT_FALSE(memoryCache()->contains(resource1.get())); 536 EXPECT_FALSE(memoryCache()->contains(resource1.get()));
537 EXPECT_FALSE(memoryCache()->contains(resource3.get())); 537 EXPECT_FALSE(memoryCache()->contains(resource3.get()));
538 } 538 }
539 539
540 } // namespace 540 } // namespace
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/fetch/ImageResource.cpp ('k') | third_party/WebKit/Source/core/fetch/RawResource.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698