Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Issue 157123002: Rename the modules and classes in webkitpy.layout_tests.servers. (Closed)

Created:
6 years, 10 months ago by Dirk Pranke
Modified:
6 years, 10 months ago
Reviewers:
ojan, scottmg
CC:
blink-reviews
Visibility:
Public.

Description

Rename the modules and classes in webkitpy.layout_tests.servers. It has long annoyed me that the lighttpd implementation of the web server code was called 'http_server', and that the base class was then called 'http_server_base', even though the base class is used by the web socket server and the crash service. This patch renames things to bring in more sanity: http_server -> lighttpd apache_http_server -> apache_http websocket_server -> pywebsocket http_server_base -> server_base There are no functional changes in this patch. R=scottmg@chromium.org, ojan@chromium.org BUG=30536 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166948

Patch Set 1 #

Patch Set 2 : fix apache class name #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1062 lines) Patch
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py View 1 chunk +1 line, -1 line 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/apache_http.py View 1 4 chunks +8 lines, -8 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server.py View 1 chunk +0 lines, -176 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py View 1 chunk +0 lines, -69 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/apache_http_unittest.py View 1 2 chunks +4 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/crash_service.py View 1 chunk +3 lines, -3 lines 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/servers/crash_service_unittest.py View 1 chunk +1 line, -1 line 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/http_server.py View 1 chunk +0 lines, -228 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/http_server_base.py View 1 chunk +0 lines, -217 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py View 1 chunk +0 lines, -58 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/http_server_unittest.py View 1 chunk +0 lines, -101 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/lighttpd.py View 2 chunks +3 lines, -3 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/lighttpd_unittest.py View 1 chunk +2 lines, -2 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/pywebsocket.py View 3 chunks +6 lines, -6 lines 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/server_base.py View 1 chunk +1 line, -1 line 0 comments Download
A + Tools/Scripts/webkitpy/layout_tests/servers/server_base_unittest.py View 1 chunk +3 lines, -3 lines 0 comments Download
D Tools/Scripts/webkitpy/layout_tests/servers/websocket_server.py View 1 chunk +0 lines, -175 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Dirk Pranke
This patch depends on https://codereview.chromium.org/150573014/ and is a prelude to far more substantive patches that ...
6 years, 10 months ago (2014-02-07 00:13:58 UTC) #1
scottmg
This seemed very odd to me when I started looking in here too. I think ...
6 years, 10 months ago (2014-02-07 00:25:30 UTC) #2
Dirk Pranke
On 2014/02/07 00:25:30, scottmg wrote: > I think the module would be better called "apache_httpd" ...
6 years, 10 months ago (2014-02-07 00:30:43 UTC) #3
scottmg
On 2014/02/07 00:30:43, Dirk Pranke wrote: > On 2014/02/07 00:25:30, scottmg wrote: > > I ...
6 years, 10 months ago (2014-02-07 00:33:44 UTC) #4
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-10 21:01:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/157123002/60001
6 years, 10 months ago (2014-02-10 21:01:45 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-10 21:58:25 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=26659
6 years, 10 months ago (2014-02-10 21:58:25 UTC) #8
Dirk Pranke
The CQ bit was checked by dpranke@chromium.org
6 years, 10 months ago (2014-02-11 20:59:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/157123002/60001
6 years, 10 months ago (2014-02-11 20:59:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/157123002/60001
6 years, 10 months ago (2014-02-11 21:24:26 UTC) #11
Dirk Pranke
Okay, the windows failures are either infra issues or flaky tests. I'll land this by ...
6 years, 10 months ago (2014-02-12 00:25:04 UTC) #12
Dirk Pranke
6 years, 10 months ago (2014-02-12 00:34:00 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 manually as r166948 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698