sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 15712002: Specialize the return type of a factory constructor to be the enclosing type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 15712002: Specialize the return type of a factory constructor to be the enclosing type. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/resolution/members.dart (revision 22988)

+++ sdk/lib/_internal/compiler/implementation/resolution/members.dart (working copy)

@@ -3743,7 +3743,9 @@

requiredParameterCount = parametersBuilder.length;

parameters = parametersBuilder.toLink();

}

- DartType returnType = compiler.resolveReturnType(element, returnNode);

+ DartType returnType = element.isFactoryConstructor()

+ ? element.getEnclosingClass().computeType(compiler)

+ : compiler.resolveReturnType(element, returnNode);

if (element.isSetter() && (requiredParameterCount != 1 ||

visitor.optionalParameterCount != 0)) {

// If there are no formal parameters, we already reported an error above.

« no previous file with comments | « no previous file | tests/language/factory_return_type_checked_test.dart » ('j') | no next file with comments »