content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 1571043002: Simplify joystick scrolling code and reenable test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 1571043002: Simplify joystick scrolling code and reenable test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address code review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/public/android/java/src/org/chromium/content/browser/input/JoystickScrollProvider.java » ('j') | content/public/android/java/src/org/chromium/content/browser/input/JoystickScrollProvider.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index b7bbcf4a397e658a310bdee6820141c556d4b7cd..941b3f5b0fa8dc1d5fbb487136552c3f78887c73 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -1593,6 +1593,7 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Screen

public void onFocusChanged(boolean gainFocus) {

mImeAdapter.onViewFocusChanged(gainFocus);

+ mJoystickScrollProvider.setEnabled(gainFocus && !mFocusedNodeEditable);

if (gainFocus) {

restoreSelectionPopupsIfNecessary();