Issue 157103002: Allow buffered stream to work with an offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 157103002: Allow buffered stream to work with an offset. (Closed)

Created:
6 years, 10 months ago by scroggo

Modified:
6 years, 10 months ago

Reviewers:
bungeman-skia, djsollen, reed1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Allow buffered stream to work with an offset. If the stream being buffered is buffered from somewhere other than the start, the SkFrontBufferedStream needs to take that into account when reporting its length. Committed: http://code.google.com/p/skia/source/detail?r=13388

Patch Set 1 #

Patch Set 2 : Add tests. #

Patch Set 3 : No need for return from test_read #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -11 lines)			Patch
	M	src/utils/SkFrontBufferedStream.cpp	View		3 chunks	+6 lines, -10 lines	0 comments	Download
	M	tests/FrontBufferedStreamTest.cpp	View	1 2	7 chunks	+94 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

scroggo

Version of https://googleplex-android-review.googlesource.com/#/c/415821/1 upstream. (Unfortunately this won't merge cleanly, since we still have an older ...

6 years, 10 months ago (2014-02-06 23:51:23 UTC) #1

scroggo

On 2014/02/07 15:31:17, djsollen wrote: > lgtm I've added some tests. PTAL

6 years, 10 months ago (2014-02-10 19:51:40 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/157103002/90001

6 years, 10 months ago (2014-02-10 21:49:07 UTC) #7

Message was sent while issue was closed.

Change committed as 13388

Expand Messages | Collapse Messages