Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1570943002: [Blimp client] Move client code into blimp::client namespace (Closed)

Created:
4 years, 11 months ago by haibinlu
Modified:
4 years, 11 months ago
Reviewers:
Kevin M, Khushal
CC:
chromium-reviews, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, dtrainor+watch-blimp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blimp client] Move client code into blimp::client namespace BUG=575763 Committed: https://crrev.com/4ed23865b9badcb5ca1f3220473ef2dad93e0e9f Cr-Commit-Position: refs/heads/master@{#368435}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -28 lines) Patch
M blimp/client/android/blimp_jni_registrar.h View 1 chunk +2 lines, -0 lines 0 comments Download
M blimp/client/android/blimp_jni_registrar.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M blimp/client/android/blimp_library_loader.h View 1 chunk +2 lines, -0 lines 0 comments Download
M blimp/client/android/blimp_library_loader.cc View 4 chunks +5 lines, -3 lines 0 comments Download
M blimp/client/android/blimp_view.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/android/blimp_view.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/android/java/src/org/chromium/blimp/BlimpLibraryLoader.java View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/android/java/src/org/chromium/blimp/BlimpView.java View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/android/java/src/org/chromium/blimp/session/BlimpClientSession.java View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/client/android/java/src/org/chromium/blimp/session/TabControlFeature.java View 2 chunks +2 lines, -2 lines 0 comments Download
M blimp/client/android/java/src/org/chromium/blimp/toolbar/Toolbar.java View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/android/toolbar.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/android/toolbar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/blimp_startup.h View 1 chunk +2 lines, -0 lines 0 comments Download
M blimp/client/blimp_startup.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_compositor.h View 2 chunks +3 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_compositor.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M blimp/client/compositor/blimp_compositor_android.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_compositor_android.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_context_provider.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_context_provider.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M blimp/client/compositor/blimp_layer_tree_settings.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_layer_tree_settings.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_output_surface.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/compositor/blimp_output_surface.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/compositor/test/dummy_layer_driver.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/compositor/test/dummy_layer_driver.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/input/blimp_input_handler_wrapper.h View 2 chunks +3 lines, -0 lines 0 comments Download
M blimp/client/input/blimp_input_handler_wrapper.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/input/blimp_input_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/input/blimp_input_manager.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/linux/blimp_display_manager.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/linux/blimp_display_manager.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/linux/blimp_main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M blimp/client/session/blimp_client_session.h View 2 chunks +4 lines, -0 lines 0 comments Download
M blimp/client/session/blimp_client_session.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/blimp_client_session_android.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/blimp_client_session_android.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/blimp_client_session_linux.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/blimp_client_session_linux.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/navigation_feature.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/navigation_feature.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/navigation_feature_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/render_widget_feature.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/render_widget_feature.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/render_widget_feature_unittest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/tab_control_feature.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/tab_control_feature.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/tab_control_feature_android.h View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/tab_control_feature_android.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/session/tab_control_feature_unittest.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
haibinlu
4 years, 11 months ago (2016-01-08 19:56:55 UTC) #2
Kevin M
lgtm
4 years, 11 months ago (2016-01-08 19:59:36 UTC) #3
Khushal
On 2016/01/08 19:59:36, Kevin M wrote: > lgtm lgtm
4 years, 11 months ago (2016-01-08 20:01:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1570943002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1570943002/20001
4 years, 11 months ago (2016-01-08 20:35:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 21:16:41 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 21:17:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ed23865b9badcb5ca1f3220473ef2dad93e0e9f
Cr-Commit-Position: refs/heads/master@{#368435}

Powered by Google App Engine
This is Rietveld 408576698