Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2165)

Unified Diff: base/message_pump.h

Issue 15709015: Make sure that the UI window created by base::MessagePumpForUI is destoyed on the same thread (Wind… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/message_pump.h
diff --git a/base/message_pump.h b/base/message_pump.h
index b2e0a425656c6962f7d960d3637e68eab48cab36..407f8f866c1501d8a259a25f39105d0e3d88bbea 100644
--- a/base/message_pump.h
+++ b/base/message_pump.h
@@ -119,6 +119,10 @@ class BASE_EXPORT MessagePump : public RefCountedThreadSafe<MessagePump> {
// used on the thread that called Run.
virtual void ScheduleDelayedWork(const TimeTicks& delayed_work_time) = 0;
+ // Called directly by MessageLoop::~MessageLoop to clean up resources that
rvargas (doing something else) 2013/06/12 00:22:22 nit: it's better to document what the method does
alexeypa (please no reviews) 2013/06/12 18:05:22 Done.
+ // must be freed on the MessageLoop's thread.
+ virtual void WillDestroyCurrentMessageLoop() {}
rvargas (doing something else) 2013/06/12 00:22:22 This class is a pure interface... let's keep all m
alexeypa (please no reviews) 2013/06/12 18:05:22 Done.
+
protected:
virtual ~MessagePump();
friend class RefCountedThreadSafe<MessagePump>;
« no previous file with comments | « base/message_loop.cc ('k') | base/message_pump_win.h » ('j') | base/message_pump_win.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698