Adds a mock for component_updater::ComponentUpdateService

Adds a mock for component_updater::ComponentUpdateService

This can be used to test that a component registers itself properly.

Its first intended use is with some upcoming tests for a new Certificate
Transparency component, modelled after CRLSetFetcher, which registers itself
only after attempting to read version information from disk.

Committed: https://crrev.com/3de53402bbf3a7247141205d65603d79695a8811
Cr-Commit-Position: refs/heads/master@{#368894}

[Rob Percival, 2016-01-08 19:20:50]

robpercival@chromium.org changed reviewers:
+ cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2016-01-08 22:59:45]

Description was changed from

==========
Adds a mock for component_updater::ComponentUpdateService

This can be used to test that a component registers itself properly.

Its first intended use is with some upcoming tests for a new Certificate
Transparency component, modelled after CRLSetFetcher, which registers itself
only after attempting to read version information from disk.
==========

to

==========
Adds a mock for component_updater::ComponentUpdateService

This can be used to test that a component registers itself properly.

Its first intended use is with some upcoming tests for a new Certificate
Transparency component, modelled after CRLSetFetcher, which registers itself
only after attempting to read version information from disk.
==========

[cpu_(ooo_6.6-7.5), 2016-01-08 22:59:46]

cpu@chromium.org changed reviewers:
+ sorin@chromium.org
- cpu@chromium.org

[cpu_(ooo_6.6-7.5), 2016-01-08 23:00:09]

changing reviewers.

[Sorin Jianu, 2016-01-11 17:54:11]

lgtm

Nice, thank you!

https://codereview.chromium.org/1570873003/diff/1/components/component_update...
File components/component_updater/component_updater_service.h (right):

https://codereview.chromium.org/1570873003/diff/1/components/component_update...
components/component_updater/component_updater_service.h:16: #include
"base/sequenced_task_runner.h"
Is the complete type definition for SequencedTaskRunner needed here? If yes, we
could remove the forward decl at 27.

[Rob Percival, 2016-01-11 19:14:30]

https://codereview.chromium.org/1570873003/diff/1/components/component_update...
File components/component_updater/component_updater_service.h (right):

https://codereview.chromium.org/1570873003/diff/1/components/component_update...
components/component_updater/component_updater_service.h:16: #include
"base/sequenced_task_runner.h"
On 2016/01/11 17:54:11, Sorin Jianu wrote:
> Is the complete type definition for SequencedTaskRunner needed here? If yes,
we
> could remove the forward decl at 27.

Actually I think this #include belongs in the mock header, as the forward
declaration should be enough here, but GMock definitely needs the complete type
definition.

[Rob Percival, 2016-01-11 19:16:10]

The CQ bit was checked by robpercival@chromium.org

[Rob Percival, 2016-01-11 19:16:10]

The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org
Link to the patchset: https://codereview.chromium.org/1570873003/#ps20001
(title: "Moves an #include from component_updater_service.h to mock")

[commit-bot: I haz the power, 2016-01-11 19:17:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570873003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570873003/20001

[commit-bot: I haz the power, 2016-01-11 19:22:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 19:22:26]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Rob Percival, 2016-01-11 19:31:42]

The CQ bit was checked by robpercival@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-11 19:33:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570873003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570873003/40001

[commit-bot: I haz the power, 2016-01-11 20:51:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 20:51:57]

Dry run: This issue passed the CQ dry run.

[Rob Percival, 2016-01-11 20:55:05]

The CQ bit was checked by robpercival@chromium.org

[Rob Percival, 2016-01-11 20:55:06]

The patchset sent to the CQ was uploaded after l-g-t-m from sorin@chromium.org
Link to the patchset: https://codereview.chromium.org/1570873003/#ps40001
(title: "Adds dependency on //base")

[commit-bot: I haz the power, 2016-01-11 20:56:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570873003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570873003/40001

[commit-bot: I haz the power, 2016-01-11 21:09:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 21:09:52]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Rob Percival, 2016-01-11 21:17:47]

robpercival@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-01-12 15:50:21]

lgtm

[Rob Percival, 2016-01-12 16:23:21]

The CQ bit was checked by robpercival@chromium.org

[commit-bot: I haz the power, 2016-01-12 16:24:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570873003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570873003/40001

[commit-bot: I haz the power, 2016-01-12 16:29:11]

Description was changed from

==========
Adds a mock for component_updater::ComponentUpdateService

This can be used to test that a component registers itself properly.

Its first intended use is with some upcoming tests for a new Certificate
Transparency component, modelled after CRLSetFetcher, which registers itself
only after attempting to read version information from disk.
==========

to

==========
Adds a mock for component_updater::ComponentUpdateService

This can be used to test that a component registers itself properly.

Its first intended use is with some upcoming tests for a new Certificate
Transparency component, modelled after CRLSetFetcher, which registers itself
only after attempting to read version information from disk.
==========

[commit-bot: I haz the power, 2016-01-12 16:29:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-12 16:31:02]

Description was changed from

==========
Adds a mock for component_updater::ComponentUpdateService

This can be used to test that a component registers itself properly.

Its first intended use is with some upcoming tests for a new Certificate
Transparency component, modelled after CRLSetFetcher, which registers itself
only after attempting to read version information from disk.
==========

to

==========
Adds a mock for component_updater::ComponentUpdateService

This can be used to test that a component registers itself properly.

Its first intended use is with some upcoming tests for a new Certificate
Transparency component, modelled after CRLSetFetcher, which registers itself
only after attempting to read version information from disk.

Committed: https://crrev.com/3de53402bbf3a7247141205d65603d79695a8811
Cr-Commit-Position: refs/heads/master@{#368894}
==========

[commit-bot: I haz the power, 2016-01-12 16:31:03]

Patchset 3 (id:??) landed as
https://crrev.com/3de53402bbf3a7247141205d65603d79695a8811
Cr-Commit-Position: refs/heads/master@{#368894}