src/parsing/preparser.cc - Issue 1570793002: [parser] parenthesized Literals are not valid AssignmentPatterns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/preparser.cc

Issue 1570793002: [parser] parenthesized Literals are not valid AssignmentPatterns (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add TODO + move ParenthesizedField line above Type-dependent fields/comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parsing/preparser.cc

diff --git a/src/parsing/preparser.cc b/src/parsing/preparser.cc

index 4af7fca7b7160293229d8d8b9c47feb7526a28fc..cca31a9bc7820d8bf23887f93d29a6669c24c134 100644

--- a/src/parsing/preparser.cc

+++ b/src/parsing/preparser.cc

@@ -591,7 +591,8 @@ PreParser::Statement PreParser::ParseVariableDeclarations(

}

- is_pattern = pattern.IsObjectLiteral() || pattern.IsArrayLiteral();

+ is_pattern = (pattern.IsObjectLiteral() || pattern.IsArrayLiteral()) &&

+ !pattern.is_parenthesized();

bool is_for_iteration_variable =

var_context == kForStatement &&

« no previous file with comments | « src/parsing/preparser.h ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »