src/parsing/parser.cc - Issue 1570793002: [parser] parenthesized Literals are not valid AssignmentPatterns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser.cc

Issue 1570793002: [parser] parenthesized Literals are not valid AssignmentPatterns (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Add TODO + move ParenthesizedField line above Type-dependent fields/comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/parsing/parser.cc

diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc

index 74fc00b7e480dbaf493282135560adae8b5698b0..335b23ad6599e3bbb534ecf19e9a491e639814e6 100644

--- a/src/parsing/parser.cc

+++ b/src/parsing/parser.cc

@@ -2366,7 +2366,9 @@ void Parser::ParseVariableDeclarations(VariableDeclarationContext var_context,

}

- bool is_pattern = pattern->IsObjectLiteral() || pattern->IsArrayLiteral();

+ bool is_pattern =

+ (pattern->IsObjectLiteral() || pattern->IsArrayLiteral()) &&

+ !pattern->is_parenthesized();

Scanner::Location variable_loc = scanner()->location();

const AstRawString* single_name =

« no previous file with comments | « src/ast/ast.h ('k') | src/parsing/parser-base.h » ('j') | no next file with comments »