Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2628)

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller.h

Issue 1570783003: [Autofill] Move functions from the AutofillPopupController to AutofillPopupLayoutModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed nit Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_popup_controller.h
diff --git a/chrome/browser/ui/autofill/autofill_popup_controller.h b/chrome/browser/ui/autofill/autofill_popup_controller.h
index 8f226988cf04757a46eef30b27ceba1393dc7bfb..df17ce6b39c19e02667c222049ecb3317c3647d0 100644
--- a/chrome/browser/ui/autofill/autofill_popup_controller.h
+++ b/chrome/browser/ui/autofill/autofill_popup_controller.h
@@ -22,6 +22,7 @@ class Rect;
namespace autofill {
+class AutofillPopupLayoutModel;
struct Suggestion;
// This interface provides data to an AutofillPopupView.
@@ -33,18 +34,10 @@ class AutofillPopupController : public AutofillPopupViewDelegate {
// Accepts the suggestion at |index|.
virtual void AcceptSuggestion(size_t index) = 0;
- // Gets the resource value for the given resource, returning -1 if the
- // resource isn't recognized.
- virtual int GetIconResourceID(const base::string16& resource_name) const = 0;
-
// Returns true if the given index refers to an element that is a warning
// rather than an Autofill suggestion.
virtual bool IsWarning(size_t index) const = 0;
- // Returns the bounds of the item at |index| in the popup, relative to
- // the top left of the popup.
- virtual gfx::Rect GetRowBounds(size_t index) = 0;
-
// Returns the number of lines of data that there are.
virtual size_t GetLineCount() const = 0;
@@ -73,6 +66,8 @@ class AutofillPopupController : public AutofillPopupViewDelegate {
// hovered or has keyboard focus.
virtual int selected_line() const = 0;
+ virtual const AutofillPopupLayoutModel& layout_model() const = 0;
+
protected:
~AutofillPopupController() override {}
};

Powered by Google App Engine
This is Rietveld 408576698