Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Unified Diff: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc

Issue 1570783003: [Autofill] Move functions from the AutofillPopupController to AutofillPopupLayoutModel (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: controller now owns the helper Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
diff --git a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
index 15b26c62e11b63f40d7621df52e879ceeaaba7a8..d68d7b380d67d9fc17e54e8da062bfe094802afe 100644
--- a/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
+++ b/chrome/browser/ui/android/autofill/autofill_popup_view_android.cc
@@ -11,6 +11,7 @@
#include "chrome/browser/ui/android/autofill/autofill_keyboard_accessory_view.h"
#include "chrome/browser/ui/android/view_android_helper.h"
#include "chrome/browser/ui/autofill/autofill_popup_controller.h"
+#include "chrome/browser/ui/autofill/autofill_popup_view_helper.h"
#include "components/autofill/core/browser/suggestion.h"
#include "components/autofill/core/common/autofill_util.h"
#include "content/public/browser/android/content_view_core.h"
@@ -25,8 +26,7 @@ namespace autofill {
AutofillPopupViewAndroid::AutofillPopupViewAndroid(
AutofillPopupController* controller)
- : controller_(controller),
- deleting_index_(-1) {}
+ : controller_(controller), deleting_index_(-1) {}
AutofillPopupViewAndroid::~AutofillPopupViewAndroid() {}
@@ -75,7 +75,7 @@ void AutofillPopupViewAndroid::UpdateBoundsAndRedrawPopup() {
const autofill::Suggestion& suggestion = controller_->GetSuggestionAt(i);
if (!suggestion.icon.empty()) {
android_icon_id = ResourceMapper::MapFromChromiumId(
- controller_->GetIconResourceID(suggestion.icon));
+ controller_->view_helper()->GetIconResourceID(suggestion.icon));
}
bool deletable =

Powered by Google App Engine
This is Rietveld 408576698