[Autofill] Move functions from the AutofillPopupController to AutofillPopupLayoutModel

chrome/browser/ui/cocoa/autofill/autofill_popup_view_bridge.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_AUTOFILL_AUTOFILL_POPUP_VIEW_BRIDGE_H_
 #define CHROME_BROWSER_UI_COCOA_AUTOFILL_AUTOFILL_POPUP_VIEW_BRIDGE_H_
 
 #include <stddef.h>
 
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/mac/scoped_nsobject.h"
 #include "base/macros.h"
+#include "base/memory/scoped_ptr.h"
 #include "chrome/browser/ui/autofill/autofill_popup_view.h"
+#include "chrome/browser/ui/autofill/autofill_popup_view_helper.h"
 #include "chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.h"
 
 @class AutofillPopupViewCocoa;
 @class NSWindow;
 
 namespace autofill {
 
 class AutofillPopupViewDelegate;
 
+class AutofillPopupViewBridgeDelegate {
+ public:
+  // Returns the bounds of the item at |index| in the popup, relative to
+  // the top left of the popup.
+  virtual gfx::Rect GetRowBounds(size_t index) = 0;
+
+  // Gets the resource value for the given resource, returning -1 if the
+  // resource isn't recognized.
+  virtual int GetIconResourceID(const base::string16& resource_name) = 0;
+};
+
 // Mac implementation of the AutofillPopupView interface.
 // Serves as a bridge to an instance of the Objective-C class which actually
 // implements the view.
-class AutofillPopupViewBridge : public AutofillPopupView {
+class AutofillPopupViewBridge : public AutofillPopupView,
+                                public AutofillPopupViewBridgeDelegate {

[Ilya Sherman, 2016/01/11 21:06:45]

The bridge is its own delegate?  The naming of this class + interface confuses
me.

[Mathieu, 2016/01/13 17:04:27]

Yes, it's rather a AutofillPopupCocoaViewDelegate (it's a way for the cocoa view
to call into the bridge).

  public:
   explicit AutofillPopupViewBridge(AutofillPopupController* controller);
 
+  // AutofillPopupViewBridgeDelegate implementation.
+  gfx::Rect GetRowBounds(size_t index) override;
+  int GetIconResourceID(const base::string16& resource_name) override;
+
  private:
   ~AutofillPopupViewBridge() override;
 
   // AutofillPopupView implementation.
   void Hide() override;
   void Show() override;
   void InvalidateRow(size_t row) override;
   void UpdateBoundsAndRedrawPopup() override;
+  void UpdatePopupBounds() override;
+  int GetAvailableWidthForRow(int row, bool with_label) override;
+  int LineFromY(int y) override;
+  gfx::Rect GetPopupBounds() override;
 
   // Set the initial bounds of the popup, including its placement.
   void SetInitialBounds();
 
   // The native Cocoa view.
   base::scoped_nsobject<AutofillPopupViewCocoa> view_;
 
+  scoped_ptr<AutofillPopupViewHelper> view_helper_;

[Ilya Sherman, 2016/01/11 21:06:45]

nit: Can you omit the scoped_ptr wrapper?

[Mathieu, 2016/01/13 17:04:27]

Done.

+
   AutofillPopupController* controller_;  // Weak.
 
   DISALLOW_COPY_AND_ASSIGN(AutofillPopupViewBridge);
 };
 
 }  // namespace autofill
 
 #endif  // CHROME_BROWSER_UI_COCOA_AUTOFILL_AUTOFILL_POPUP_VIEW_BRIDGE_H_