XFA: Remove many relative includes in xfa/

XFA: Remove many relative includes in xfa/

Also remove useless files.

R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/c909ce872d999a17ffd44afdc88caf2de43e6cba

[Lei Zhang, 2016-01-08 07:51:55]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-01-08 18:47:18]

https://codereview.chromium.org/1570743002/diff/1/xfa/include/foxitxfa.h
File xfa/include/foxitxfa.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/include/foxitxfa.h#newc...
xfa/include/foxitxfa.h:9: #ifndef _FOXIT_XFA_H_
nit: symbol should at least be _FOXITXFA_H_ regardless of whether you want to
include the full path or remove the leading hyphen (no hyphen between foxit and
xfa).

https://codereview.chromium.org/1570743002/diff/1/xfa/include/fwl/adapter/fwl...
File xfa/include/fwl/adapter/fwl_adaptertimermgr.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/include/fwl/adapter/fwl...
xfa/include/fwl/adapter/fwl_adaptertimermgr.h:7: #ifndef _FWL_ADAPTER_TIMERMGR_H
nit: again, no hyphen between adapter and timermgr.

https://codereview.chromium.org/1570743002/diff/1/xfa/include/fwl/fwl.h
File xfa/include/fwl/fwl.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/include/fwl/fwl.h#newco...
xfa/include/fwl/fwl.h:11: #include "xfa/include/fwl/core/fwl_error.h"
nit: alphabetize (at your peril due to IWYU).

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/include/fde.h
File xfa/src/fdp/include/fde.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/include/fde.h#n...
xfa/src/fdp/include/fde.h:9: #ifndef _FDE
nit: should be _H_ at least.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
File xfa/src/fdp/src/css/fde_csscache.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
xfa/src/fdp/src/css/fde_csscache.cpp:8: #include "fde_csscache.h"
nit: full path here, then blank line.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
File xfa/src/fdp/src/css/fde_cssdatatable.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
xfa/src/fdp/src/css/fde_cssdatatable.cpp:8: #include "fde_cssdatatable.h"
ditto.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
xfa/src/fdp/src/css/fde_cssdatatable.cpp:10: extern "C" {
Next time: Why do we need this exern "C"?

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
File xfa/src/fdp/src/css/fde_cssdeclaration.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
xfa/src/fdp/src/css/fde_cssdeclaration.cpp:8: #include "fde_cssdeclaration.h"
ditto, check all of these.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fgas.h
File xfa/src/fgas/include/fgas.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fgas.h...
xfa/src/fgas/include/fgas.h:9: #ifndef _FGAS_
nit: should be FGAS_H_ at a minium (missing H_).

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fx_mem.h
File xfa/src/fgas/include/fx_mem.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fx_mem...
xfa/src/fgas/include/fx_mem.h:7: #ifndef _FX_MEMORY
This conflicts with other FX_MEMORY symbols if we make it _H_ ? S/B FX_MEM_H_ at
miniumum

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fx_tbk.h
File xfa/src/fgas/include/fx_tbk.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fx_tbk...
xfa/src/fgas/include/fx_tbk.h:7: #ifndef _FX_TEXTBREAK
nit: not match file name

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fx_utl.h
File xfa/src/fgas/include/fx_utl.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fx_utl...
xfa/src/fgas/include/fx_utl.h:7: #ifndef _FX_UTILS
nit: not match filename

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/crt/fx_cpm...
File xfa/src/fgas/src/crt/fx_cpmgr.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/crt/fx_cpm...
xfa/src/fgas/src/crt/fx_cpmgr.cpp:8: #ifdef _FXCP
huh?

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/fgas_base.h
File xfa/src/fgas/src/fgas_base.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/fgas_base....
xfa/src/fgas/src/fgas_base.h:9: #ifndef _FXMATH_BASE_
nit: not match filename.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_linebreak.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_linebreak.cpp:9: extern const FX_LINEBREAKTYPE
gs_FX_LineBreak_PairTable[64][32] = {
nit: no extern keyword in .cpp files.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_rtfbreak.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_rtfbreak.h:7: #ifndef _FX_RTFBREAK_IMP
nit: not match filename.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/foxitlib.h
File xfa/src/foxitlib.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/foxitlib.h#newcode9
xfa/src/foxitlib.h:9: #ifndef _FOXIT_LIB_H_
nit: no hyphen between in filename.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fwl/src/core/fwl_wi...
File xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fwl/src/core/fwl_wi...
xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp:13: #define FWL_NORMALMATRIX
nit: FLW_NORMALMATRIX not used elsewhere.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/BC_BarCod...
File xfa/src/fxbarcode/BC_BarCode.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/BC_BarCod...
xfa/src/fxbarcode/BC_BarCode.cpp:57: #include
"xfa/src/fxbarcode/pdf417/BC_PDF417DetectorResult.h"
nit: alphabetize (at your peril due to IWYU).

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/BC_Binary...
File xfa/src/fxbarcode/BC_BinaryBitmap.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/BC_Binary...
xfa/src/fxbarcode/BC_BinaryBitmap.cpp:23: #include "xfa/src/fxbarcode/barcode.h"
nit: alphabetize, etc.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/BC_Librar...
File xfa/src/fxbarcode/BC_Library.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/BC_Librar...
xfa/src/fxbarcode/BC_Library.cpp:7: #include "xfa/src/fxbarcode/barcode.h"
More includes than lines of code.  Some may not be needed.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/BC_Librar...
xfa/src/fxbarcode/BC_Library.cpp:100: CBC_PDF417ECModulusGF::Initialize(e);
do these really need to take an argument?

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/barcode.h
File xfa/src/fxbarcode/barcode.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/barcode.h...
xfa/src/fxbarcode/barcode.h:10: #include "utils.h"
nit: Full path.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxfa/src/app/xfa_ch...
File xfa/src/fxfa/src/app/xfa_checksum.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxfa/src/app/xfa_ch...
xfa/src/fxfa/src/app/xfa_checksum.cpp:9: #include "xfa_checksum.h"
nit: full path,comes first.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
File xfa/src/fxfa/src/app/xfa_ffConfigAcc.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffConfigAcc.cpp:9: #include "xfa_ffConfigAcc.h"
nitto.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
File xfa/src/fxfa/src/app/xfa_ffbarcode.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxfa/src/app/xfa_ff...
xfa/src/fxfa/src/app/xfa_ffbarcode.cpp:14: #include "xfa_ffbarcode.h"
nit: many other places.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxfa/src/common/xfa...
File xfa/src/fxfa/src/common/xfa_common.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxfa/src/common/xfa...
xfa/src/fxfa/src/common/xfa_common.h:11: #include "xfa_utils.h"
nit: alphabetize.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxjse/src/value.cpp
File xfa/src/fxjse/src/value.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxjse/src/value.cpp...
xfa/src/fxjse/src/value.cpp:11: #include <math.h>
std headers first.

[Lei Zhang, 2016-01-08 23:21:33]

I tried sorting the #includes in file and failed. IWYU will have to wait for
another time.

https://codereview.chromium.org/1570743002/diff/1/xfa/include/foxitxfa.h
File xfa/include/foxitxfa.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/include/foxitxfa.h#newc...
xfa/include/foxitxfa.h:9: #ifndef _FOXIT_XFA_H_
On 2016/01/08 18:47:17, Tom Sepez wrote:
> nit: symbol should at least be _FOXITXFA_H_ regardless of whether you want to
> include the full path or remove the leading hyphen (no hyphen between foxit
and
> xfa).

The header guards can all be fixed in a separate CL.

https://codereview.chromium.org/1570743002/diff/1/xfa/include/fwl/fwl.h
File xfa/include/fwl/fwl.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/include/fwl/fwl.h#newco...
xfa/include/fwl/fwl.h:11: #include "xfa/include/fwl/core/fwl_error.h"
On 2016/01/08 18:47:17, Tom Sepez wrote:
> nit: alphabetize (at your peril due to IWYU).

Also another CL for another day. Otherwise this CL will go on forever.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
File xfa/src/fdp/src/css/fde_csscache.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
xfa/src/fdp/src/css/fde_csscache.cpp:8: #include "fde_csscache.h"
On 2016/01/08 18:47:17, Tom Sepez wrote:
> nit: full path here, then blank line.

I can fix the CWD #includes in another CL as well.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
File xfa/src/fdp/src/css/fde_cssdatatable.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fdp/src/css/fde_css...
xfa/src/fdp/src/css/fde_cssdatatable.cpp:10: extern "C" {
On 2016/01/08 18:47:17, Tom Sepez wrote:
> Next time: Why do we need this exern "C"?

We don't. Removed.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fx_mem.h
File xfa/src/fgas/include/fx_mem.h (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/include/fx_mem...
xfa/src/fgas/include/fx_mem.h:7: #ifndef _FX_MEMORY
On 2016/01/08 18:47:18, Tom Sepez wrote:
> This conflicts with other FX_MEMORY symbols if we make it _H_ ? S/B FX_MEM_H_
at
> miniumum

There's no conflict. Fix can happen in another CL.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/crt/fx_cpm...
File xfa/src/fgas/src/crt/fx_cpmgr.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/crt/fx_cpm...
xfa/src/fgas/src/crt/fx_cpmgr.cpp:8: #ifdef _FXCP
On 2016/01/08 18:47:18, Tom Sepez wrote:
> huh?

Deleted this file.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/layout/fx_...
File xfa/src/fgas/src/layout/fx_linebreak.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fgas/src/layout/fx_...
xfa/src/fgas/src/layout/fx_linebreak.cpp:9: extern const FX_LINEBREAKTYPE
gs_FX_LineBreak_PairTable[64][32] = {
On 2016/01/08 18:47:18, Tom Sepez wrote:
> nit: no extern keyword in .cpp files.

Done.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fwl/src/core/fwl_wi...
File xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fwl/src/core/fwl_wi...
xfa/src/fwl/src/core/fwl_widgetmgrimp.cpp:13: #define FWL_NORMALMATRIX
On 2016/01/08 18:47:18, Tom Sepez wrote:
> nit: FLW_NORMALMATRIX not used elsewhere.

Gone.

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/BC_Librar...
File xfa/src/fxbarcode/BC_Library.cpp (right):

https://codereview.chromium.org/1570743002/diff/1/xfa/src/fxbarcode/BC_Librar...
xfa/src/fxbarcode/BC_Library.cpp:100: CBC_PDF417ECModulusGF::Initialize(e);
On 2016/01/08 18:47:18, Tom Sepez wrote:
> do these really need to take an argument?

Outside the scope of this CL. File a bug? I also see "Destory" below.

[Tom Sepez, 2016-01-08 23:36:08]

LGTM

[Lei Zhang, 2016-01-08 23:44:45]

Description was changed from

==========
XFA: Remove many relative includes in xfa/

Also remove useless files.
==========

to

==========
XFA: Remove many relative includes in xfa/

Also remove useless files.

R=tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/c909ce872d999a17ffd44afdc88caf2de43e...
==========

[Lei Zhang, 2016-01-08 23:44:46]

Committed patchset #2 (id:20001) manually as
c909ce872d999a17ffd44afdc88caf2de43e6cba (presubmit successful).