third_party/WebKit/LayoutTests/editing/execCommand/insertunorderedlist-crash-in-domsubtreemodified-event.html - Issue 1570733002: [Editing][BugFix] Check editability in InserListCommand::listifyParagraph

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/editing/execCommand/insertunorderedlist-crash-in-domsubtreemodified-event.html

Issue 1570733002: [Editing][BugFix] Check editability in InserListCommand::listifyParagraph (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../resources/testharness.js"></script>

	3 <script src="../../resources/testharnessreport.js"></script>

	4 <dl>

	5 >

	6 </dl>

	7 <table>

	8 <div id="log"></div>

	9 <script>

	10 document.addEventListener("DOMSubtreeModified", function (event) {
	yosin_UTC9 2016/01/12 05:51:44 Can we repro this w/o mutation event handler? Can we repro this w/o mutation event handler?
	11 document.execCommand('InsertUnorderedList');
	yosin_UTC9 2016/01/12 05:51:44 It seems this execCommand apples to non-editable e It seems this execCommand apples to non-editable element.
	12 event.srcElement.contentEditable = "true";

	13 });

	14

	15 test(function () {

	16 document.execCommand("SelectAll");

	17 window.getSelection().getRangeAt(0).insertNode(document.createElement("div") );

	18 });

	19 </script>

OLD	NEW