Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2018)

Unified Diff: scripts/master/factory/commands.py

Issue 157073002: Bot update! (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Remove environ Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/bot_update.py » ('j') | scripts/slave/bot_update.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/master/factory/commands.py
diff --git a/scripts/master/factory/commands.py b/scripts/master/factory/commands.py
index d89cc5be9cce03c1a5364e5b4a0f0a97e7c5f1d7..17899d069888b764453f0b40cd75054f8c32a22a 100644
--- a/scripts/master/factory/commands.py
+++ b/scripts/master/factory/commands.py
@@ -935,10 +935,14 @@ class FactoryCommands(object):
cmd = ['python', self._bot_update_tool, '--specs', gclient_specs]
PROPERTIES = {
- 'root': '%(root:~src)s',
+ 'root': '%(root:-)s',
'issue': '%(issue:-)s',
'patchset': '%(patchset:-)s',
- 'master': '%(mastername:-)s'
+ 'master': '%(mastername:-)s',
+ 'revision': '%(revision:-)s',
+ 'patch_url': '%(patch_url:-)s',
+ 'slave_name': '%(slavename:-)s',
+ 'builder_name': '%(buildername:-)s',
}
for property_name, property_expr in PROPERTIES.iteritems():
@@ -947,7 +951,7 @@ class FactoryCommands(object):
cmd.extend(['--%s' % property_name, property_value])
if server:
- cmd.extend(['--server', server])
+ cmd.extend(['--rietveld_server', server])
if revision_mapping:
cmd.extend(['--revision-mapping=%s' % json.dumps(revision_mapping)])
« no previous file with comments | « no previous file | scripts/slave/bot_update.py » ('j') | scripts/slave/bot_update.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698