Change install_emulator_deps.py to support Arm build

Change install_emulator_deps.py to support Arm build

BUG=575321
Committed: https://crrev.com/c45428fe66c9f914a288416c27ad0494fab58cb1
Cr-Commit-Position: refs/heads/master@{#368437}

[Yoland Yan(Google), 2016-01-07 21:08:32]

yolandyan@google.com changed reviewers:
+ jbudorick@chromium.org, mikecase@chromium.org, rnephew@google.com

[rnephew (Wrong account), 2016-01-07 21:21:45]

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
File build/android/install_emulator_deps.py (right):

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:26: DEFAULT_ABI = 'x86'
What does abi stand for? Just switching it to architecture might make it more
easily understood.

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:205: r'\s*([0-9]+)- Google APIs Intel x86
Atom System Image, Google Inc.'
These seem very specific. Are we guaranteed they wont change and need constant
maintenance? If so, is there a more general regex that could be used to
differentiate?

[mikecase (-- gone --), 2016-01-07 22:27:31]

Mostly just a bunch of nits.

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
File build/android/install_emulator_deps.py (right):

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:47: abi: target architecture, x86 or arm
s/target architecture/target abi/ ¯\_(ツ)_/¯

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:192: """Download system image files using
tools/android under third_party
I can see this documentation getting out of date. Maybe just rewrite as
"""Download system image files."""

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:197: google: use Google APIs instead of
AOSP build
Google build instead of AOSP build?
or
Google APIs instead of AOSP APIs?
or

from you help comment on the arg is sounds like it is...
Google Android image instead of AOSP image.

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:254: help='The targeted arch for emulator
system image',
s/targeted arch/target abi/ ¯_(ツ)_/¯
Edit

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:278: # TODO(yolandyan), make
options.google and options.arm multually exclusive
delete

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:299: logging.info('system image for
android-%d already present, skipping.',
Might want to add the info about the abi and google to this log.

[Yoland Yan(Google), 2016-01-08 00:00:40]

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
File build/android/install_emulator_deps.py (right):

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:26: DEFAULT_ABI = 'x86'
On 2016/01/07 21:21:44, rnephew wrote:
> What does abi stand for? Just switching it to architecture might make it more
> easily understood.

All the other place in this script and in avd.py/emulator.py uses ABI instead of
ARCH. I am stick with this, but added a comment

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:47: abi: target architecture, x86 or arm
On 2016/01/07 22:27:30, mikecase wrote:
> s/target architecture/target abi/ ¯\_(ツ)_/¯

You dropped your arm, here \ you g..wait a min..
done.

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:192: """Download system image files using
tools/android under third_party
On 2016/01/07 22:27:30, mikecase wrote:
> I can see this documentation getting out of date. Maybe just rewrite as
> """Download system image files."""

Done.

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:197: google: use Google APIs instead of
AOSP build
On 2016/01/07 22:27:31, mikecase wrote:
> Google build instead of AOSP build?
> or
> Google APIs instead of AOSP APIs?
> or
> 
> from you help comment on the arg is sounds like it is...
> Google Android image instead of AOSP image.

Done.

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:205: r'\s*([0-9]+)- Google APIs Intel x86
Atom System Image, Google Inc.'
On 2016/01/07 21:21:44, rnephew wrote:
> These seem very specific. Are we guaranteed they wont change and need constant
> maintenance? If so, is there a more general regex that could be used to
> differentiate? 

The current ones won't change because these targets are used by others outside
Google with links like
this(https://dl.google.com/android/repository/sys-img/android/sys-img.xml). The
future ones might (it happened before), but it doesn't follow a changing pattern
so it's hard to use regex to generalize.

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:254: help='The targeted arch for emulator
system image',
On 2016/01/07 22:27:31, mikecase wrote:
> s/targeted arch/target abi/ ¯_(ツ)_/¯
> Edit

Done.

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:278: # TODO(yolandyan), make
options.google and options.arm multually exclusive
On 2016/01/07 22:27:30, mikecase wrote:
> delete

Done.

https://codereview.chromium.org/1570623003/diff/1/build/android/install_emula...
build/android/install_emulator_deps.py:299: logging.info('system image for
android-%d already present, skipping.',
On 2016/01/07 22:27:30, mikecase wrote:
> Might want to add the info about the abi and google to this log.

Done.

[mikecase (-- gone --), 2016-01-08 00:59:28]

lgtm w/ final nit.

https://codereview.chromium.org/1570623003/diff/20001/build/android/install_e...
File build/android/install_emulator_deps.py (right):

https://codereview.chromium.org/1570623003/diff/20001/build/android/install_e...
build/android/install_emulator_deps.py:301: "Google" if options.google else
"AOSP", options.abi,
super nit: single quotes (there are some other places with double quotes other
than this)

[Yoland Yan(Google), 2016-01-08 19:38:00]

The CQ bit was checked by yolandyan@google.com

[Yoland Yan(Google), 2016-01-08 19:38:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
mikecase@chromium.org
Link to the patchset: https://codereview.chromium.org/1570623003/#ps60001
(title: "Updates the avd.py")

[commit-bot: I haz the power, 2016-01-08 19:38:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1570623003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1570623003/60001

[commit-bot: I haz the power, 2016-01-08 21:19:06]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-08 21:19:46]

Description was changed from

==========
Change install_emulator_deps.py to support Arm build

BUG=575321
==========

to

==========
Change install_emulator_deps.py to support Arm build

BUG=575321

Committed: https://crrev.com/c45428fe66c9f914a288416c27ad0494fab58cb1
Cr-Commit-Position: refs/heads/master@{#368437}
==========

[commit-bot: I haz the power, 2016-01-08 21:19:46]

Patchset 4 (id:??) landed as
https://crrev.com/c45428fe66c9f914a288416c27ad0494fab58cb1
Cr-Commit-Position: refs/heads/master@{#368437}