dart2js: Simplification of the IrBuilderVisitor.

dart2js: Simplification of the IrBuilderVisitor.

Remove more simple helpers by inlining them and simplify.

BUG=
R=asgerf@google.com

Committed: https://github.com/dart-lang/sdk/commit/5180cef547abea486bf08c4492cf0da3a1fafaec

[Kevin Millikin (Google), 2016-01-09 01:47:58]

kmillikin@google.com changed reviewers:
+ asgerf@google.com

[Kevin Millikin (Google), 2016-01-09 01:47:59]

I'm not sure you'll agree with all of these changes.

[asgerf, 2016-01-11 21:16:36]

LGTM (with or without the changes in my comments)

https://codereview.chromium.org/1570603006/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (left):

https://codereview.chromium.org/1570603006/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2511: return
buildStaticNoSuchGetter(getter);
The buildStaticNoSuchGetter seemed kind of convenient to have for code like
this.

https://codereview.chromium.org/1570603006/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1570603006/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2162: ir.Primitive value,
I think this was better before, but I don't feel strongly it has to be one way
or the other.

[Kevin Millikin (Google), 2016-01-12 15:58:47]

https://codereview.chromium.org/1570603006/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart (right):

https://codereview.chromium.org/1570603006/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart:2162: ir.Primitive value,
On 2016/01/11 21:16:36, asgerf wrote:
> I think this was better before, but I don't feel strongly it has to be one way
> or the other.

I guess I can see that.  I've changed it back (but not returning a Primitive
from the void function setValue).

[Kevin Millikin (Google), 2016-01-12 17:15:35]

Description was changed from

==========
dart2js: Simplification of the IrBuilderVisitor.

Remove more simple helpers by inlining them and simplify.

BUG=
==========

to

==========
dart2js: Simplification of the IrBuilderVisitor.

Remove more simple helpers by inlining them and simplify.

BUG=
R=asgerf@google.com

Committed:
https://github.com/dart-lang/sdk/commit/5180cef547abea486bf08c4492cf0da3a1fafaec
==========

[Kevin Millikin (Google), 2016-01-12 17:15:37]

Committed patchset #3 (id:40001) manually as
5180cef547abea486bf08c4492cf0da3a1fafaec (presubmit successful).