Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: pkg/analyzer_cli/test/driver_test.dart

Issue 1570603004: Bootloader cleanup. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: review_nit Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer_cli/test/boot_loader_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer_cli/test/driver_test.dart
diff --git a/pkg/analyzer_cli/test/driver_test.dart b/pkg/analyzer_cli/test/driver_test.dart
index d85b8188230eb8549d261f1ee4dcc00bd2760911..244788c174717685d6a90a69170657f627f9781f 100644
--- a/pkg/analyzer_cli/test/driver_test.dart
+++ b/pkg/analyzer_cli/test/driver_test.dart
@@ -12,9 +12,7 @@ import 'package:analyzer/source/error_processor.dart';
import 'package:analyzer/src/generated/engine.dart';
import 'package:analyzer/src/generated/error.dart';
import 'package:analyzer/src/generated/source.dart';
-import 'package:analyzer/src/plugin/plugin_configuration.dart';
import 'package:analyzer/src/services/lint.dart';
-import 'package:analyzer_cli/src/bootloader.dart';
import 'package:analyzer_cli/src/driver.dart';
import 'package:analyzer_cli/src/options.dart';
import 'package:path/path.dart' as path;
@@ -351,56 +349,7 @@ linter:
// });
});
- group('Bootloader', () {
- group('plugin processing', () {
- test('bad format', () {
- BootLoader loader = new BootLoader();
- loader.createImage([
- '--options',
- path.join(testDirectory, 'data/bad_plugin_options.yaml'),
- path.join(testDirectory, 'data/test_file.dart')
- ]);
- expect(
- errorSink.toString(),
- equals('Plugin configuration skipped: Unrecognized plugin config '
- 'format, expected `YamlMap`, got `YamlList` '
- '(line 2, column 4)\n'));
- });
- test('plugin config', () {
- BootLoader loader = new BootLoader();
- Image image = loader.createImage([
- '--options',
- path.join(testDirectory, 'data/plugin_options.yaml'),
- path.join(testDirectory, 'data/test_file.dart')
- ]);
- var plugins = image.config.plugins;
- expect(plugins, hasLength(1));
- expect(plugins.first.name, equals('my_plugin1'));
- });
- group('plugin validation', () {
- test('requires class name', () {
- expect(
- validate(new PluginInfo(
- name: 'test_plugin', libraryUri: 'my_package/foo.dart')),
- isNotNull);
- });
- test('requires library URI', () {
- expect(
- validate(
- new PluginInfo(name: 'test_plugin', className: 'MyPlugin')),
- isNotNull);
- });
- test('check', () {
- expect(
- validate(new PluginInfo(
- name: 'test_plugin',
- className: 'MyPlugin',
- libraryUri: 'my_package/foo.dart')),
- isNull);
- });
- });
- });
- });
+
}
const emptyOptionsFile = 'data/empty_options.yaml';
« no previous file with comments | « pkg/analyzer_cli/test/boot_loader_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698