Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1570603004: Bootloader cleanup. (Closed)

Created:
4 years, 11 months ago by pquitslund
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : review_nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -249 lines) Patch
A + pkg/analyzer_cli/lib/src/boot_loader.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/analyzer_cli/lib/src/bootloader.dart View 1 chunk +0 lines, -196 lines 0 comments Download
M pkg/analyzer_cli/test/all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/boot_loader_test.dart View 1 1 chunk +96 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 2 chunks +1 line, -52 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
4 years, 11 months ago (2016-01-08 00:25:39 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1570603004/diff/1/pkg/analyzer_cli/test/boot_loader_test.dart File pkg/analyzer_cli/test/boot_loader_test.dart (right): https://codereview.chromium.org/1570603004/diff/1/pkg/analyzer_cli/test/boot_loader_test.dart#newcode5 pkg/analyzer_cli/test/boot_loader_test.dart:5: library analyzer_cli.test.boot_loader; "boot_loader" --> "boot_loader_test"?
4 years, 11 months ago (2016-01-08 01:05:37 UTC) #3
pquitslund
Thanks! https://codereview.chromium.org/1570603004/diff/1/pkg/analyzer_cli/test/boot_loader_test.dart File pkg/analyzer_cli/test/boot_loader_test.dart (right): https://codereview.chromium.org/1570603004/diff/1/pkg/analyzer_cli/test/boot_loader_test.dart#newcode5 pkg/analyzer_cli/test/boot_loader_test.dart:5: library analyzer_cli.test.boot_loader; On 2016/01/08 01:05:37, Brian Wilkerson wrote: ...
4 years, 11 months ago (2016-01-11 21:40:37 UTC) #4
pquitslund
4 years, 11 months ago (2016-01-11 22:13:49 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1dcec8c35f8fc3eec3a354281613a0a30dd52475 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698