Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 157053010: Move async_file_test_helper.* to content/public/test/ (Closed)

Created:
6 years, 10 months ago by pilgrim_google
Modified:
6 years, 10 months ago
CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, dcheng, kinuko+watch, jamesr, darin (slow to review)
Visibility:
Public.

Description

Move async_file_test_helper.* to content/public/test/ BUG=338338 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251069

Patch Set 1 #

Patch Set 2 : fix namespace references #

Total comments: 1

Patch Set 3 : re-up with similarity=25 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -488 lines) Patch
M chrome/browser/sync_file_system/local/syncable_file_system_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/blob_url_request_job_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/copy_or_move_file_validator_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/copy_or_move_operation_delegate_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/dragged_file_util_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_file_stream_reader_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/fileapi/file_system_operation_impl_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_quota_client_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_system_url_request_job_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/file_writer_delegate_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/local_file_util_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/obfuscated_file_util_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/plugin_private_file_system_backend_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/fileapi/upload_file_system_file_element_reader_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
A + content/public/test/async_file_test_helper.h View 1 2 2 chunks +40 lines, -37 lines 0 comments Download
A + content/public/test/async_file_test_helper.cc View 13 chunks +35 lines, -39 lines 0 comments Download
D webkit/browser/fileapi/async_file_test_helper.h View 1 chunk +0 lines, -109 lines 0 comments Download
D webkit/browser/fileapi/async_file_test_helper.cc View 1 chunk +0 lines, -270 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
pilgrim_google
6 years, 10 months ago (2014-02-11 17:48:39 UTC) #1
pilgrim_google
6 years, 10 months ago (2014-02-11 19:02:59 UTC) #2
kinuko
lgtm if you fix the compile errors
6 years, 10 months ago (2014-02-12 02:17:11 UTC) #3
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 10 months ago (2014-02-12 21:40:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/157053010/70001
6 years, 10 months ago (2014-02-12 21:45:17 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-12 22:45:28 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=49925
6 years, 10 months ago (2014-02-12 22:45:30 UTC) #7
pilgrim_google
6 years, 10 months ago (2014-02-13 00:55:03 UTC) #8
kinuko
you'll need stamp from content/public/test owners...
6 years, 10 months ago (2014-02-13 01:15:52 UTC) #9
darin (slow to review)
LGTM https://codereview.chromium.org/157053010/diff/70001/content/public/test/async_file_test_helper.h File content/public/test/async_file_test_helper.h (right): https://codereview.chromium.org/157053010/diff/70001/content/public/test/async_file_test_helper.h#newcode1 content/public/test/async_file_test_helper.h:1: // Copyright (c) 2013 The Chromium Authors. All ...
6 years, 10 months ago (2014-02-13 04:57:17 UTC) #10
pilgrim_google
The CQ bit was checked by pilgrim@chromium.org
6 years, 10 months ago (2014-02-13 15:03:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pilgrim@chromium.org/157053010/290001
6 years, 10 months ago (2014-02-13 15:03:43 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 17:12:22 UTC) #13
Message was sent while issue was closed. 
Change committed as 251069

Powered by Google App Engine
This is Rietveld 408576698