Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 157053008: Removed tls_edit post process rules from nacl_irt (Closed)

Created:
6 years, 10 months ago by David Yen
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Removed tls_edit post process rules from nacl_irt Now that build_nexe.py is in charge of applying tls_edit to IRT Nexe's, we no longer need separate rules to apply tls_edit. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3127 TEST= trybots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252237

Patch Set 1 #

Patch Set 2 : Rebased to master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -129 lines) Patch
M ppapi/native_client/native_client.gyp View 1 2 chunks +5 lines, -129 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
David Yen
I've moved the changes to remove tls_edit from the following patch: https://codereview.chromium.org/139803011/ We need to ...
6 years, 10 months ago (2014-02-10 22:07:26 UTC) #1
bradn
lgtm
6 years, 10 months ago (2014-02-10 22:23:09 UTC) #2
noelallen1
lgtm
6 years, 10 months ago (2014-02-12 00:41:14 UTC) #3
David Yen
Added Brad's chromium account and Noel's google account to the review list to match the ...
6 years, 10 months ago (2014-02-18 19:45:13 UTC) #4
bradnelson
lgtm
6 years, 10 months ago (2014-02-20 00:01:42 UTC) #5
David Yen
The CQ bit was checked by dyen@chromium.org
6 years, 10 months ago (2014-02-20 00:03:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/157053008/60001
6 years, 10 months ago (2014-02-20 01:17:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/157053008/60001
6 years, 10 months ago (2014-02-20 05:06:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/157053008/60001
6 years, 10 months ago (2014-02-20 09:02:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dyen@chromium.org/157053008/60001
6 years, 10 months ago (2014-02-20 12:26:09 UTC) #10
commit-bot: I haz the power
Change committed as 252237
6 years, 10 months ago (2014-02-20 15:36:35 UTC) #11
Dmitry Lomov (no reviews)
A revert of this CL has been created in https://codereview.chromium.org/172473003/ by dslomov@chromium.org. The reason for ...
6 years, 10 months ago (2014-02-20 15:47:48 UTC) #12
binji1
6 years, 10 months ago (2014-02-20 21:11:39 UTC) #13
Message was sent while issue was closed.
On 2014/02/20 15:47:48, Dmitry Lomov (chromium) wrote:
> A revert of this CL has been created in
> https://codereview.chromium.org/172473003/ by mailto:dslomov@chromium.org.
> 
> The reason for reverting is: Google Chrome compilation breakage
> 
>
http://build.chromium.org/p/chromium.chrome/builders/Google%2520Chrome%2520Ma....

Note that this change also broke the NaCl SDK tests:

http://build.chromium.org/p/client.nacl.sdk/builders/linux-sdk-multi/builds/6...

[27888:27914:0220/094426:ERROR:nacl_browser.cc(275)] Failed to open NaCl IRT
file
"/mnt/data/b/build/slave/linux-sdk-multi/build/src/out/Release/nacl_irt_x86_64.nexe":
-4
[27888:27914:0220/094428:ERROR:nacl_process_host.cc(642)] NaCl process launch
failed: could not find all the resources needed to launch the process

Powered by Google App Engine
This is Rietveld 408576698