Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: net/quic/quic_protocol.cc

Issue 1570443010: relnote: Change the QuicBlockedFrame in QuicFrame from a pointer to in-place. No functional change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@04_CL_111628540
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_protocol.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_protocol.cc
diff --git a/net/quic/quic_protocol.cc b/net/quic/quic_protocol.cc
index a5fb29cf2dd31738bf94dcd20587fd2a43b82a81..284f1850330310294408c021767ac2d5e465aec2 100644
--- a/net/quic/quic_protocol.cc
+++ b/net/quic/quic_protocol.cc
@@ -346,7 +346,7 @@ QuicFrame::QuicFrame(QuicGoAwayFrame* frame)
QuicFrame::QuicFrame(QuicWindowUpdateFrame* frame)
: type(WINDOW_UPDATE_FRAME), window_update_frame(frame) {}
-QuicFrame::QuicFrame(QuicBlockedFrame* frame)
+QuicFrame::QuicFrame(QuicBlockedFrame frame)
: type(BLOCKED_FRAME), blocked_frame(frame) {}
ostream& operator<<(ostream& os, const QuicStopWaitingFrame& sent_info) {
@@ -558,7 +558,7 @@ ostream& operator<<(ostream& os, const QuicFrame& frame) {
break;
}
case BLOCKED_FRAME: {
- os << "type { BLOCKED_FRAME } " << *(frame.blocked_frame);
+ os << "type { BLOCKED_FRAME } " << frame.blocked_frame;
break;
}
case STREAM_FRAME: {
@@ -713,6 +713,7 @@ RetransmittableFrames::~RetransmittableFrames() {
case PADDING_FRAME:
case MTU_DISCOVERY_FRAME:
case PING_FRAME:
+ case BLOCKED_FRAME:
break;
case STREAM_FRAME:
delete frame.stream_frame;
@@ -735,9 +736,6 @@ RetransmittableFrames::~RetransmittableFrames() {
case WINDOW_UPDATE_FRAME:
delete frame.window_update_frame;
break;
- case BLOCKED_FRAME:
- delete frame.blocked_frame;
- break;
case NUM_FRAME_TYPES:
DCHECK(false) << "Cannot delete type: " << frame.type;
}
« no previous file with comments | « net/quic/quic_protocol.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698