Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Side by Side Diff: net/quic/quic_packet_generator.cc

Issue 1570443010: relnote: Change the QuicBlockedFrame in QuicFrame from a pointer to in-place. No functional change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@04_CL_111628540
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_framer_test.cc ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_packet_generator.h" 5 #include "net/quic/quic_packet_generator.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "net/quic/quic_bug_tracker.h" 8 #include "net/quic/quic_bug_tracker.h"
9 #include "net/quic/quic_fec_group.h" 9 #include "net/quic/quic_fec_group.h"
10 #include "net/quic/quic_flags.h" 10 #include "net/quic/quic_flags.h"
(...skipping 20 matching lines...) Expand all
31 should_send_ack_(false), 31 should_send_ack_(false),
32 should_send_stop_waiting_(false), 32 should_send_stop_waiting_(false),
33 max_packet_length_(kDefaultMaxPacketSize) {} 33 max_packet_length_(kDefaultMaxPacketSize) {}
34 34
35 QuicPacketGenerator::~QuicPacketGenerator() { 35 QuicPacketGenerator::~QuicPacketGenerator() {
36 for (QuicFrame& frame : queued_control_frames_) { 36 for (QuicFrame& frame : queued_control_frames_) {
37 switch (frame.type) { 37 switch (frame.type) {
38 case PADDING_FRAME: 38 case PADDING_FRAME:
39 case MTU_DISCOVERY_FRAME: 39 case MTU_DISCOVERY_FRAME:
40 case PING_FRAME: 40 case PING_FRAME:
41 case BLOCKED_FRAME:
41 break; 42 break;
42 case STREAM_FRAME: 43 case STREAM_FRAME:
43 delete frame.stream_frame; 44 delete frame.stream_frame;
44 break; 45 break;
45 case ACK_FRAME: 46 case ACK_FRAME:
46 delete frame.ack_frame; 47 delete frame.ack_frame;
47 break; 48 break;
48 case RST_STREAM_FRAME: 49 case RST_STREAM_FRAME:
49 delete frame.rst_stream_frame; 50 delete frame.rst_stream_frame;
50 break; 51 break;
51 case CONNECTION_CLOSE_FRAME: 52 case CONNECTION_CLOSE_FRAME:
52 delete frame.connection_close_frame; 53 delete frame.connection_close_frame;
53 break; 54 break;
54 case GOAWAY_FRAME: 55 case GOAWAY_FRAME:
55 delete frame.goaway_frame; 56 delete frame.goaway_frame;
56 break; 57 break;
57 case WINDOW_UPDATE_FRAME: 58 case WINDOW_UPDATE_FRAME:
58 delete frame.window_update_frame; 59 delete frame.window_update_frame;
59 break; 60 break;
60 case BLOCKED_FRAME:
61 delete frame.blocked_frame;
62 break;
63 case STOP_WAITING_FRAME: 61 case STOP_WAITING_FRAME:
64 delete frame.stop_waiting_frame; 62 delete frame.stop_waiting_frame;
65 break; 63 break;
66 case NUM_FRAME_TYPES: 64 case NUM_FRAME_TYPES:
67 DCHECK(false) << "Cannot delete type: " << frame.type; 65 DCHECK(false) << "Cannot delete type: " << frame.type;
68 } 66 }
69 } 67 }
70 } 68 }
71 69
72 void QuicPacketGenerator::OnCongestionWindowChange( 70 void QuicPacketGenerator::OnCongestionWindowChange(
(...skipping 321 matching lines...) Expand 10 before | Expand all | Expand 10 after
394 392
395 FecSendPolicy QuicPacketGenerator::fec_send_policy() { 393 FecSendPolicy QuicPacketGenerator::fec_send_policy() {
396 return packet_creator_.fec_send_policy(); 394 return packet_creator_.fec_send_policy();
397 } 395 }
398 396
399 void QuicPacketGenerator::set_fec_send_policy(FecSendPolicy fec_send_policy) { 397 void QuicPacketGenerator::set_fec_send_policy(FecSendPolicy fec_send_policy) {
400 packet_creator_.set_fec_send_policy(fec_send_policy); 398 packet_creator_.set_fec_send_policy(fec_send_policy);
401 } 399 }
402 400
403 } // namespace net 401 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_framer_test.cc ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698