Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Side by Side Diff: net/quic/quic_framer.cc

Issue 1570443010: relnote: Change the QuicBlockedFrame in QuicFrame from a pointer to in-place. No functional change. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@04_CL_111628540
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_framer.h" 5 #include "net/quic/quic_framer.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 374 matching lines...) Expand 10 before | Expand all | Expand 10 after
385 return 0; 385 return 0;
386 } 386 }
387 break; 387 break;
388 case WINDOW_UPDATE_FRAME: 388 case WINDOW_UPDATE_FRAME:
389 if (!AppendWindowUpdateFrame(*frame.window_update_frame, &writer)) { 389 if (!AppendWindowUpdateFrame(*frame.window_update_frame, &writer)) {
390 QUIC_BUG << "AppendWindowUpdateFrame failed"; 390 QUIC_BUG << "AppendWindowUpdateFrame failed";
391 return 0; 391 return 0;
392 } 392 }
393 break; 393 break;
394 case BLOCKED_FRAME: 394 case BLOCKED_FRAME:
395 if (!AppendBlockedFrame(*frame.blocked_frame, &writer)) { 395 if (!AppendBlockedFrame(frame.blocked_frame, &writer)) {
396 QUIC_BUG << "AppendBlockedFrame failed"; 396 QUIC_BUG << "AppendBlockedFrame failed";
397 return 0; 397 return 0;
398 } 398 }
399 break; 399 break;
400 default: 400 default:
401 RaiseError(QUIC_INVALID_FRAME_DATA); 401 RaiseError(QUIC_INVALID_FRAME_DATA);
402 QUIC_BUG << "QUIC_INVALID_FRAME_DATA"; 402 QUIC_BUG << "QUIC_INVALID_FRAME_DATA";
403 return 0; 403 return 0;
404 } 404 }
405 ++i; 405 ++i;
(...skipping 1854 matching lines...) Expand 10 before | Expand all | Expand 10 after
2260 2260
2261 bool QuicFramer::RaiseError(QuicErrorCode error) { 2261 bool QuicFramer::RaiseError(QuicErrorCode error) {
2262 DVLOG(1) << "Error: " << QuicUtils::ErrorToString(error) 2262 DVLOG(1) << "Error: " << QuicUtils::ErrorToString(error)
2263 << " detail: " << detailed_error_; 2263 << " detail: " << detailed_error_;
2264 set_error(error); 2264 set_error(error);
2265 visitor_->OnError(this); 2265 visitor_->OnError(this);
2266 return false; 2266 return false;
2267 } 2267 }
2268 2268
2269 } // namespace net 2269 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_framer_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698