Use addBool() and BoolReader in summaries.

pkg/analyzer/tool/summary/generate.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /**
  * This file contains code to generate serialization/deserialization logic for
  * summaries based on an "IDL" description of the summary format (written in
  * stylized Dart).
  *
  * For each class in the "IDL" input, two corresponding classes are generated:
@@ skipping 383 matching lines @@
           String valueName = '_' + field.name;
           String condition = '$valueName != null';
           String writeCode;
           if (fieldType.isList ||
               fieldType.typeName == 'String' ||
               _idl.classes.containsKey(fieldType.typeName)) {
             String offsetName = 'offset_' + field.name;
             condition = '$offsetName != null';
             writeCode = 'fbBuilder.addOffset($index, $offsetName);';
           } else if (fieldType.typeName == 'bool') {
-            // TODO(scheglov) implement booleans merging?
             condition = '$valueName == true';
-            writeCode = 'fbBuilder.addInt8($index, 1);';
+            writeCode = 'fbBuilder.addBool($index, true);';
           } else if (fieldType.typeName == 'int') {
             condition += ' && $valueName != ${defaultValue(fieldType)}';
             writeCode = 'fbBuilder.addInt32($index, $valueName);';
           } else if (_idl.enums.containsKey(fieldType.typeName)) {
             condition += ' && $valueName != ${defaultValue(fieldType)}';
             writeCode = 'fbBuilder.addInt32($index, $valueName.index);';
           }
           if (writeCode == null) {
             throw new UnimplementedError('Writing type ${fieldType.typeName}');
           }
@@ skipping 75 matching lines @@
       out('};');
       // Write getters.
       cls.fields.asMap().forEach((index, field) {
         String fieldName = field.name;
         idlModel.FieldType type = field.type;
         String typeName = type.typeName;
         // Prepare "readLines" or "readCode" + "def" + "readSuffix"
         List<String> readLines;
         String readCode;
         String def = defaultValue(type);
-        String readSuffix = '';
         if (type.isList) {
           if (typeName == 'int') {
             String itemCode = 'const fb.Int32Reader()';
             readCode = 'const fb.ListReader<int>($itemCode)';
           } else if (typeName == 'String') {
             String itemCode = 'const fb.StringReader()';
             readCode = 'const fb.ListReader<String>($itemCode)';
           } else {
             String itemCode = '$typeName>(const _${typeName}Reader()';
             readCode = 'const fb.ListReader<$itemCode)';
           }
         } else if (typeName == 'bool') {
-          // TODO(scheglov) implement booleans merging?
-          def = '0';
-          readCode = 'const fb.Int8Reader()';
-          readSuffix = ' == 1';
+          readCode = 'const fb.BoolReader()';
         } else if (typeName == 'int') {
           readCode = 'const fb.Int32Reader()';
         } else if (typeName == 'String') {
           readCode = 'const fb.StringReader()';
         } else if (_idl.enums.containsKey(typeName)) {
           readLines = <String>[
             'int index = const fb.Int32Reader().vTableGet(_bp, $index, 0);',
             'return $typeName.values[index];'
           ];
         } else if (_idl.classes.containsKey(typeName)) {
           readCode = 'const _${typeName}Reader()';
         }
         assert(readCode != null || readLines != null);
         // Write the getter implementation.
         out();
         out('@override');
         String returnType = dartType(type);
         if (readLines != null) {
           out('$returnType get $fieldName {');
           indent(() {
             readLines.forEach(out);
           });
           out('}');
         } else {
-          String expr = '$readCode.vTableGet(_bp, $index, $def)$readSuffix';
+          String expr = '$readCode.vTableGet(_bp, $index, $def)';
           out('$returnType get $fieldName => $expr;');
         }
       });
     });
     out('}');
   }
 
   /**
    * Return the documentation text of the given [node], or `null` if the [node]
    * does not have a comment.  Each line is `\n` separated.
@@ skipping 10 matching lines @@
       return token.lexeme.split('\n').map((String line) {
         if (line.startsWith(indent)) {
           line = line.substring(indent.length);
         }
         return line;
       }).join('\n');
     }
     return null;
   }
 }