Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 157033012: Improved variable-related assembler comments in fullcode. (Closed)

Created:
6 years, 10 months ago by Sven Panne
Modified:
6 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Improved variable-related assembler comments in fullcode. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19320

Patch Set 1 #

Patch Set 2 : Removed ugly comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M src/arm/full-codegen-arm.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 5 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 10 months ago (2014-02-12 08:40:24 UTC) #1
Benedikt Meurer
LGTM
6 years, 10 months ago (2014-02-12 08:41:09 UTC) #2
Sven Panne
6 years, 10 months ago (2014-02-12 12:06:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698