API to Convert Java Bitmap Config to SkBitmap::Config

content/browser/android/content_view_core_impl.cc

Index: content/browser/android/content_view_core_impl.cc
diff --git a/content/browser/android/content_view_core_impl.cc b/content/browser/android/content_view_core_impl.cc
index fefc89104c42d7c69e081309dab3400f1d204a01..357d2a9b585851b3f9fff9c2c1a894d59d3e1824 100644
--- a/content/browser/android/content_view_core_impl.cc
+++ b/content/browser/android/content_view_core_impl.cc
@@ -698,14 +698,15 @@ void ContentViewCoreImpl::ShowPastePopup(int x_dip, int y_dip) {
 
 void ContentViewCoreImpl::GetScaledContentBitmap(
     float scale,
+    jobject jbitmap_config,

[jdduke (slow), 2014/02/26 20:33:09]

Any reason we couldn't have simply used an SkBitmap::Config argument type here,
rather than forcing the caller to supply a Java-backed bitmap config? Can we not
include SkBitmap.h in public files?

[powei, 2014/02/26 20:38:19]

This was my question in ps#3.  I think the argument was that keeping it jobject
lessens the dependency on skia downstream.

     const base::Callback<void(bool, const SkBitmap&)>& result_callback) {
   RenderWidgetHostViewAndroid* view = GetRenderWidgetHostViewAndroid();
   if (!view) {
     result_callback.Run(false, SkBitmap());
     return;
   }
-
-  view->GetScaledContentBitmap(scale, result_callback);
+  SkBitmap::Config skbitmap_format = gfx::ConvertToSkiaConfig(jbitmap_config);
+  view->GetScaledContentBitmap(scale, skbitmap_format, result_callback);
 }
 
 void ContentViewCoreImpl::StartContentIntent(const GURL& content_url) {