API to Convert Java Bitmap Config to SkBitmap::Config

ui/gfx/android/java_bitmap.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_GFX_ANDROID_JAVA_BITMAP_H_
 #define UI_GFX_ANDROID_JAVA_BITMAP_H_
 
 #include <jni.h>
 
 #include "base/android/scoped_java_ref.h"
+#include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/gfx/size.h"
 
-class SkBitmap;
+namespace gfx {
 
-namespace gfx {
+// Define Bitmap Config values like BITMAP_CONFIG_ARGB_8888 in a
+// way that ensures they're always the same than their Java counterpart.
+
+enum BitmapConfig {
+#define DEFINE_BITMAP_CONFIG(x, y) BITMAP_##x = y,
+#include "base/android/bitmap_config_list.h"

[Yaron, 2014/02/19 18:26:14]

Why is this in base? It's only used in ui and seems like a better fit here.
Please move the files related to enum generation to ui. 

[sivag, 2014/02/20 17:13:59]

Can you please advice over this 
1. i changed as below base/android/bitmap_config_list.h ->
ui/gfx/android/bitmap_config_list.h

2. base/android/java/src/org/chromium/base/BitmapFormat.template -> ?

3.What about the package inside BitmapFormat.template
package org.chromium.ui.gfx; -> ?

+#undef DEFINE_BITMAP_CONFIG
+};
 
 // This class wraps a JNI AndroidBitmap object to make it easier to use. It
 // handles locking and unlocking of the underlying pixels, along with wrapping
 // various JNI methods.
 class GFX_EXPORT JavaBitmap {
  public:
+

[bulach, 2014/02/19 12:42:58]

nit: remove extra \n

   explicit JavaBitmap(jobject bitmap);
   ~JavaBitmap();
 
   inline void* pixels() { return pixels_; }
   inline const gfx::Size& size() const { return size_; }
   // Formats are in android/bitmap.h; e.g. ANDROID_BITMAP_FORMAT_RGBA_8888
   inline int format() const { return format_; }
   inline uint32_t stride() const { return stride_; }
 
   // Registers methods with JNI and returns true if succeeded.
@@ skipping 12 matching lines @@
 GFX_EXPORT base::android::ScopedJavaLocalRef<jobject> ConvertToJavaBitmap(
     const SkBitmap* skbitmap);
 
 GFX_EXPORT SkBitmap CreateSkBitmapFromJavaBitmap(JavaBitmap& jbitmap);
 
 // If the resource loads successfully, it will be resized to |size|.
 // Note: If the source resource is smaller than |size|, quality may suffer.
 GFX_EXPORT SkBitmap CreateSkBitmapFromResource(const char* name,
                                                gfx::Size size);
 
+// Returns a Skia config value for the requested input java Bitmap.Config.
+GFX_EXPORT SkBitmap::Config ConvertToSkiaConfig(jobject bitmap_config);

[danakj, 2014/02/19 15:42:31]

name this JavaConfigToSkiaConfig()?

+
 }  // namespace gfx
 
 #endif  // UI_GFX_ANDROID_JAVA_BITMAP_H_