Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: scripts/slave/recipe_modules/test_results/resources/upload_gtest_test_results.py

Issue 1570293002: Flakiness dashboard: turn off json logging completely until determining an appropriate amount to lo… (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/test_results/resources/upload_gtest_test_results.py
diff --git a/scripts/slave/recipe_modules/test_results/resources/upload_gtest_test_results.py b/scripts/slave/recipe_modules/test_results/resources/upload_gtest_test_results.py
index d22a0ccd496b2cfb44becaf31fda1ec6dd03ca0d..974d5bd08a77dfe27e9f9602f3966bc72639575c 100755
--- a/scripts/slave/recipe_modules/test_results/resources/upload_gtest_test_results.py
+++ b/scripts/slave/recipe_modules/test_results/resources/upload_gtest_test_results.py
@@ -144,18 +144,8 @@ def main():
# Set uploading timeout in case appengine server is having problem.
# 120 seconds are more than enough to upload test results.
- try:
- test_results_uploader.upload_test_results(
- options.test_results_server, attrs, files, 120)
- except test_results_uploader.PermanentError as e:
- # Dump the offending input gtest json to stderr to aid in debugging.
- print>>sys.stderr, 'Dump of test results json causing a permanent error:'
- for _, json_filename in files:
- with file(json_filename) as json_file:
- print>>sys.stderr, '%s:' % json_filename
- sys.stderr.write(json_file.read())
- print>>sys.stderr, ''
- raise
+ test_results_uploader.upload_test_results(
+ options.test_results_server, attrs, files, 120)
return 0
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698