third_party/WebKit/Source/modules/mediastream/MediaStream.cpp - Issue 1570263002: MediaRecorder: make EventListener and stop if receiving on{add,remove}track from WebMediaStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaStream.cpp

Issue 1570263002: MediaRecorder: make EventListener and stop if receiving on{add,remove}track from WebMediaStream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/mediastream/MediaStream-add-remove-tracks.html ('K') | « third_party/WebKit/Source/modules/mediarecorder/MediaRecorder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/MediaStream.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp b/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp

index ce02f73e2d0bec8d031f9ca8702f7b90f154dd57..75ec1247ac92f559331b5233fb35526b857034f7 100644

--- a/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/MediaStream.cpp

@@ -206,6 +206,7 @@ void MediaStream::addTrack(MediaStreamTrack* track, ExceptionState& exceptionSta

m_descriptor->setActive(true);

scheduleDispatchEvent(Event::create(EventTypeNames::active));

}

+ scheduleDispatchEvent(MediaStreamTrackEvent::create(EventTypeNames::addtrack, false, false, track));

MediaStreamCenter::instance().didAddMediaStreamTrack(m_descriptor, track->component());

}

@@ -240,6 +241,7 @@ void MediaStream::removeTrack(MediaStreamTrack* track, ExceptionState& exception

m_descriptor->setActive(false);

scheduleDispatchEvent(Event::create(EventTypeNames::inactive));

}

+ scheduleDispatchEvent(MediaStreamTrackEvent::create(EventTypeNames::removetrack, false, false, track));

MediaStreamCenter::instance().didRemoveMediaStreamTrack(m_descriptor, track->component());

}