Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 157023003: Use validating IPC enum macros in websocket messages (Closed)

Created:
6 years, 10 months ago by Tom Sepez
Modified:
6 years, 10 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Use validating IPC enum macros in websocket messages This is part of a long-running background task to remove the remaining uses of the unchecked IPC_ENUM_TRAITS() macro. BUG=246708 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249805

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M content/common/websocket.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/common/websocket_messages.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Sepez
tyoshino, please review.
6 years, 10 months ago (2014-02-06 23:16:15 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
6 years, 10 months ago (2014-02-07 03:24:37 UTC) #2
Tom Sepez
The CQ bit was checked by tsepez@chromium.org
6 years, 10 months ago (2014-02-07 18:13:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/157023003/1
6 years, 10 months ago (2014-02-07 18:15:11 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-07 21:58:36 UTC) #5
Message was sent while issue was closed.
Change committed as 249805

Powered by Google App Engine
This is Rietveld 408576698